Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UnitTest: scripts/test/CronEvent.t does not exit cleanly #237

Closed
bschmalhofer opened this issue Jul 22, 2020 · 2 comments
Closed

UnitTest: scripts/test/CronEvent.t does not exit cleanly #237

bschmalhofer opened this issue Jul 22, 2020 · 2 comments
Assignees
@bschmalhofer
Labels
bug Something isn't working as intended
Milestone
OTOBO 10.0.3

Comments

@bschmalhofer
Copy link
Contributor

ERROR: OTOBO-otobo.UnitTest-14 Perl: 5.32.0 OS: linux Time: Wed Jul 22 13:45:02 2020 7457 7458 Message: Need Schedule! 7459 7460 Traceback (7302): 7461 Module: Kernel::System::CronEvent::NextEventGet Line: 78 7462 Module: scripts/test/CronEvent.t Line: 311 7463 7464 ERROR: OTOBO-otobo.UnitTest-14 Perl: 5.32.0 OS: linux Time: Wed Jul 22 13:45:02 2020 7465 7466 Message: Need Schedule! 7467 7468 Traceback (7302): 7469 Module: Kernel::System::CronEvent::NextEventGet Line: 78 7470 Module: scripts/test/CronEvent.t Line: 311 7471 7472 Can't locate object method "OTRSTimeZoneGet" via package "Kernel::System::DateTime" at /opt/otobo/Kernel/System/CronEvent.pm line 93. 7473 scripts/test/CronEvent.t .................. 7474 ok 1 - No Params NextEvent() 7475 ok 2 - No Schedule NextEvent() 7476 1..2 7477 Dubious, test returned 255 (wstat 65280, 0xff00) 7478 All 2 subtests passed

@bschmalhofer bschmalhofer added the bug Something isn't working as intended label Jul 22, 2020
@bschmalhofer bschmalhofer added this to the OTOBO 10.1 milestone Jul 22, 2020
@bschmalhofer bschmalhofer self-assigned this Jul 22, 2020
@bschmalhofer
Copy link
Contributor Author

There are different issues at play here.

  1. Naming of identifiers
  2. Invalid local time
  3. Obscure Perl bugs

Regarding 1:

this is an easy fix. OTRSTimeZone => OTOBOTimeZone

Regarding 2:

Kernel::System::CronEvent produces invalid local times. The CPAN module DateTimeresponds with an exception. See https://metacpan.org/pod/DateTime#Invalid-Local-Times . This makes two tests fail. Let's skip these tests for now and create a separate issue for the invalid local times.

Regarding 3:

scripts/test/CronEvent.t claims that specific Perl versions are crashing.

# Broken on certain Perl 5.28 versions due to a Perl crash that we can't work around.

I don't know what these crashes are. Let's remove the blacklist and check whether there are any crashes.

bschmalhofer added a commit that referenced this issue Jul 22, 2020
@bschmalhofer
Issue #237: fix naming confusion OTRSTimeZone => OTOBOTimeZone
7162013 
Spezifically: OTRSTimeZoneGet() is now OTOBOTimeZoneGet();
And the config key is 'OTOBOTimeZone'.
bschmalhofer added a commit that referenced this issue Jul 22, 2020
@bschmalhofer
Issue #237: skip the tests that span daylight savings switches
bf66eb5
bschmalhofer added a commit that referenced this issue Jul 22, 2020
@bschmalhofer
Issue #237: do not blacklist Perl versions
ddf0e65 
File a bugreport to P5P if Perl really crashes.
@bschmalhofer bschmalhofer modified the milestones: OTOBO 10.1, OTOBO 10.0.3 Aug 19, 2020
@bschmalhofer
Copy link
Contributor Author

Looks good after applying the fixes for #238. Closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bschmalhofer bschmalhofer

Labels
bug Something isn't working as intended
Projects
None yet
Milestone
OTOBO 10.0.3
Development

No branches or pull requests
1 participant
@bschmalhofer