Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for SysConfig setting AuthSyncModule::LDAP::Charset #2346

Closed
bschmalhofer opened this issue Jun 12, 2023 · 1 comment
Closed

Remove support for SysConfig setting AuthSyncModule::LDAP::Charset #2346

bschmalhofer opened this issue Jun 12, 2023 · 1 comment
Labels
tidying Tidying of the code
Milestone
OTOBO 11.0

Comments

@bschmalhofer
Copy link
Contributor

In Kernel/Config/Defaults.pm there is:

# In case you need to use OTOBO in iso-charset, you can define this
# by using this option (converts utf-8 data from LDAP to iso).
#    $Self->{'AuthSyncModule::LDAP::Charset'} = 'iso-8859-1';

But AFAIK OTOBO no longer supports non-utf8 charsets in the database. Therefore I propose to remove support for this feature.
@bschmalhofer bschmalhofer added the tidying Tidying of the code label Jun 12, 2023
@bschmalhofer bschmalhofer added this to the OTOBO 11.0 milestone Jun 12, 2023
bschmalhofer added a commit that referenced this issue Mar 6, 2024
@bschmalhofer
Issue #2346: remove support for charset related SysConfig settings:
343a291 
'AuthModule::LDAP::Charset' and 'AuthModule::LDAP::Charset'.
Because the charset that is used internally in OTOBO is always utf-8.
bschmalhofer added a commit that referenced this issue Mar 6, 2024
@bschmalhofer
Issue #2346: add some TODO comments
121e4f0 
because the code can be simplified. The data received from LDAP
is always UTF-8 encoded. Or an upgraded Perl string.
bschmalhofer added a commit that referenced this issue Mar 7, 2024
@bschmalhofer
Issue #2346: remove support for charset related SysConfig settings:
459b7a0 
'AuthModule::LDAP::Charset' and 'AuthModule::LDAP::Charset'.
Because the charset that is used internally in OTOBO is always utf-8.
bschmalhofer added a commit that referenced this issue Mar 7, 2024
@bschmalhofer
Issue #2346: add some TODO comments
f7f096b 
because the code can be simplified. The data received from LDAP
is always UTF-8 encoded. Or an upgraded Perl string.
@bschmalhofer
Copy link
Contributor Author

The PR is merged. No complaints so far. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tidying Tidying of the code
Projects
None yet
Milestone
OTOBO 11.0
Development

No branches or pull requests
1 participant
@bschmalhofer