Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the setting DefaultCharset #2316

Closed
bschmalhofer opened this issue May 24, 2023 · 1 comment
Closed

Remove the setting DefaultCharset #2316

bschmalhofer opened this issue May 24, 2023 · 1 comment
Assignees
@bschmalhofer
Labels
tidying Tidying of the code
Milestone
OTOBO 11.0

Comments

@bschmalhofer
Copy link
Contributor

This is in Kernel/Config/Defaults.pm.

    # DEPRECATED. Compatibilty setting for older 3.0 code.
    # Internal charset must always be utf-8.
    $Self->{DefaultCharset} = 'utf-8';

Deprecated since OTRS 4. Let's finally remove it.
@bschmalhofer bschmalhofer added the tidying Tidying of the code label May 24, 2023
@bschmalhofer bschmalhofer added this to the OTOBO 11.0 milestone May 24, 2023
@bschmalhofer bschmalhofer self-assigned this May 24, 2023
bschmalhofer added a commit that referenced this issue May 24, 2023
@bschmalhofer
Issue #2316: Eliminate $Self->{DefaultCharset}
f183b87 
That setting was deprecated since OTRS 4
bschmalhofer added a commit that referenced this issue May 24, 2023
@bschmalhofer
Merge pull request #2318 from RotherOSS/issue-#2316-default_charset
d1fd27a 
Issue #2316: Eliminate $Self->{DefaultCharset}
@bschmalhofer
Copy link
Contributor Author

PR is merged, assuming that there are no repercussions. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bschmalhofer bschmalhofer

Labels
tidying Tidying of the code
Projects
None yet
Milestone
OTOBO 11.0
Development

No branches or pull requests
1 participant
@bschmalhofer