Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old OTRS Orange on pop up search close button #2150

Closed
DasMetaphysischeparadoxon opened this issue Feb 2, 2023 · 3 comments · Fixed by #2230
Closed

Old OTRS Orange on pop up search close button #2150

DasMetaphysischeparadoxon opened this issue Feb 2, 2023 · 3 comments · Fixed by #2230
Assignees
Labels
style Beautify please
Milestone

Comments

@DasMetaphysischeparadoxon
Copy link
Contributor

DasMetaphysischeparadoxon commented Feb 2, 2023

Hi,

every pop up search in OTOBO has the close button in the OTRS orange. i would like to see this replaced once by the OTOBO blue. The topic is perhaps not so important and would also be a matter of taste.

Current OTOBO:
orange_hover

My suggestion:
blue_hover

I found the OTRS color here:

.Dialog > .Header .Close:hover i {
color: #E57633;
}

and for my screenshot i used #0000fc

best regards,
~ DMP

@svenoe svenoe added the style Beautify please label Feb 6, 2023
@svenoe
Copy link
Contributor

svenoe commented Feb 6, 2023

Please compare other dialogs, I woud assume, that our font color (the almost black) would be more fitting here.

@DasMetaphysischeparadoxon
Copy link
Contributor Author

The color that fades more into black is already set (#00023c). On my screenshots the close button is also shown when hovering over it. When hovering I would then use a lighter color again, hence my suggestion with the blue (#0000fc).

svenoe pushed a commit that referenced this issue Mar 15, 2023
)

* remove hover effect for dialog close button

---------

Co-authored-by: DasMetaphysischeparadoxon <[email protected]>
@svenoe
Copy link
Contributor

svenoe commented Mar 15, 2023

After some discussion, the hover color was completely removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
style Beautify please
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants