Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for SysConfig setting UnitTest::DefaultDirectory #2067

Closed
bschmalhofer opened this issue Dec 25, 2022 · 1 comment
Closed

Remove support for SysConfig setting UnitTest::DefaultDirectory #2067

bschmalhofer opened this issue Dec 25, 2022 · 1 comment
Labels
good first issue Good for newcomers unittests Requests wrt unittests
Milestone
OTOBO 11.0.1

Comments

@bschmalhofer
Copy link
Contributor

In ./Kernel/System/Console/Command/Dev/UnitTest/Run.pm there is support for `UnitTest::DefaultDirectory'. This SysConfig setting isn't documented anywhere and AFAIK not used anywhere. I propose to remove it.

    # Allow specification of a default directory to limit test execution.
    # TODO: eliminate this
    my $DefaultDirectory = $Kernel::OM->Get('Kernel::Config')->Get('UnitTest::DefaultDirectory');

See also #2064.
@bschmalhofer bschmalhofer added good first issue Good for newcomers unittests Requests wrt unittests labels Dec 25, 2022
@bschmalhofer bschmalhofer added this to the OTOBO 11.0 milestone Dec 25, 2022
@bschmalhofer bschmalhofer changed the title Remove support for SysConfig setting UnitTest::DefaultDirector Remove support for SysConfig setting UnitTest::DefaultDirectory Dec 25, 2022
bschmalhofer added a commit that referenced this issue Dec 25, 2022
@bschmalhofer
Issue #2067: remove support for UnitTest::DefaultDirectory
c527779
bschmalhofer added a commit that referenced this issue Dec 25, 2022
@bschmalhofer
Merge pull request #2069 from RotherOSS/issue-#2067-unittest_defaultd…
2b06858 
…irectory

Issue #2067: remove support for UnitTest::DefaultDirectory
@bschmalhofer
Copy link
Contributor Author

UnitTest::DefaultDirectory is no longer considered. Closing this issue.

@bschmalhofer bschmalhofer mentioned this issue Apr 4, 2023
Closed
@bschmalhofer bschmalhofer mentioned this issue Apr 11, 2023
Closed
@bschmalhofer bschmalhofer modified the milestones: OTOBO 11.0, OTOBO 11.0.1 May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers unittests Requests wrt unittests
Projects
None yet
Milestone
OTOBO 11.0.1
Development

No branches or pull requests
1 participant
@bschmalhofer