Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect from HTTP does not honor OTOBO_WEB_HTTPS_PORT #1892

Closed
1 task done
bschmalhofer opened this issue Aug 30, 2022 · 4 comments
Closed
1 task done

Redirect from HTTP does not honor OTOBO_WEB_HTTPS_PORT #1892

bschmalhofer opened this issue Aug 30, 2022 · 4 comments
Assignees
Labels
bug Something isn't working as intended
Milestone

Comments

@bschmalhofer
Copy link
Contributor

bschmalhofer commented Aug 30, 2022

In .env there is the following setup:


# HTTP options
# In the HTTPS case http:// redirects to https://
# Set OTOBO_WEB_HTTP_PORT when the HTTP port is not 80
OTOBO_WEB_HTTP_PORT=81

# set OTOBO_WEB_HTTPS_PORT when the HTTPS port is not 443
OTOBO_WEB_HTTPS_PORT=543

Thus I would expect that fetching http://localhost:81/otobo/index.pl would redirect to https://localhost:543/otobo/index.pl . But the redirect is to https://localhost/otobo/index.pl .

TODO:

  • Honor OTOBO_WEB_HTTPS_PORT when redirecting to HTTPS
@bschmalhofer bschmalhofer added the bug Something isn't working as intended label Aug 30, 2022
@bschmalhofer bschmalhofer added this to the OTOBO 10.1.6 milestone Aug 30, 2022
@bschmalhofer bschmalhofer self-assigned this Aug 30, 2022
@bschmalhofer
Copy link
Contributor Author

bschmalhofer commented Sep 1, 2022

Tested with the port 443 either set implicitly or explicitly in .env . Using Firefox we get an redirect e.g. to https://localhost:443/otobo/index.pl . But at least under Firefox the ugly :443 is not displayed in the address field.
Setting the port 543 in .env works too. Of course the :543 stays in the address field.

Applying the PRs.

bschmalhofer added a commit that referenced this issue Sep 1, 2022
Issue #1892: include the HTTPS port when redirecting
@bschmalhofer
Copy link
Contributor Author

The default value 443 should also be set for the "OTOBO Nginx with Kerberos" Docker image.

bschmalhofer added a commit that referenced this issue Oct 1, 2022
@bschmalhofer
Copy link
Contributor Author

Tested this again with:

  • set OTOBO_WEB_HTTP_PORT=81 in .env
  • set OTOBO_WEB_HTTPS_PORT=1443 in .env
  • docker-compose up -d which restarted the nginx container
  • Clearing the browser cache
  • Open http://localhost:81/otobo/index.pl in Browser

Got a redirect to https://localhost:1443/otobo/index.pl which worked fine.

Trusting that it also works for the Kerberos image. Closing this issue.

@bschmalhofer
Copy link
Contributor Author

Reopen because OTOBO_WEB_HTTPS_PORT was not passed on to the container in docker-compose/otobo-override-https-kerberos.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as intended
Projects
None yet
Development

No branches or pull requests

1 participant