Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit test regression in CmdOutput.t #1802

Closed
bschmalhofer opened this issue Jun 1, 2022 · 3 comments
Closed

Unit test regression in CmdOutput.t #1802

bschmalhofer opened this issue Jun 1, 2022 · 3 comments
Assignees
@bschmalhofer
Labels
bug Something isn't working as intended
Milestone
OTOBO 10.0.18

Comments

@bschmalhofer
Copy link
Contributor

The output is:

#   Failed test 'Selenium cmd output test generated at Wed Jun  1 13:08:27 2022 - found on screen'
#   at /opt/otobo/scripts/test/Selenium/Output/Dashboard/CmdOutput.t line 76.
#     searched: "<html><!--                                        "...
#   can't find: "Selenium cmd output test generated at Wed Jun  1 1"...
#         LCSS: "Selenium cmd output test generated at Wed Jun "
# LCSS context: "   \x{0a}Selenium cmd output test generated at Wed Jun "
# Looks like you failed 1 test of 5.

Looks like double space are squashed somewhere. It would be good to find out whether the squashing is intended before fixing the test script.
@bschmalhofer bschmalhofer added the bug Something isn't working as intended label Jun 1, 2022
@bschmalhofer bschmalhofer added this to the OTOBO 10.1.5 milestone Jun 1, 2022
@bschmalhofer bschmalhofer self-assigned this Jun 1, 2022
bschmalhofer added a commit that referenced this issue Jun 7, 2022
@bschmalhofer
Issue #1802: Perl 5.24 is the minimum Perl version
a54ab6b 
instead of Perl 5.20
bschmalhofer added a commit that referenced this issue Jun 7, 2022
@bschmalhofer
Issue #1802: quote the argument of 'echo'
5016def 
Otherwise the test string would be interpreted as a list of strings,
implicitly squashing multiple spaces into a single space.
bschmalhofer added a commit that referenced this issue Jun 7, 2022
@bschmalhofer
Merge pull request #1812 from RotherOSS/issue-#1802-cmd_output
a92b453 
Issue #1802 cmd output
@bschmalhofer
Copy link
Contributor Author

This was just a side effect of not quoting the argument of the shell command echo. Test looks fine now. Closing this issue.

@bschmalhofer
Copy link
Contributor Author

Reopening as the same effect also occurs in the rel-10_0 branch.

bschmalhofer added a commit that referenced this issue Mar 4, 2023
@bschmalhofer
Issue #1802: backport the fix from rel-10_1 to rel-10_0
b873b1a
@bschmalhofer bschmalhofer reopened this Mar 4, 2023
bschmalhofer added a commit that referenced this issue Mar 4, 2023
@bschmalhofer
Merge pull request #2209 from RotherOSS/issue-#1802-fix_in_rel_10_0
37de904 
Issue #1802: backport the fix from rel-10_1 to rel-10_0
bschmalhofer added a commit that referenced this issue Mar 4, 2023
@bschmalhofer
Merge pull request #2210 from RotherOSS/issue-#1802-fix_in_rel_10_0
4f4a9ff 
Issue #1802: backport the fix from rel-10_1 to rel-10_0
@bschmalhofer
Copy link
Contributor Author

PR is merged after some confusion as I first merged into rel1-10_1. Closing this issue again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bschmalhofer bschmalhofer

Labels
bug Something isn't working as intended
Projects
None yet
Milestone
OTOBO 10.0.18
Development

No branches or pull requests
1 participant
@bschmalhofer