Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make error messages of the public interface less leaky #1622

Closed
bschmalhofer opened this issue Feb 17, 2022 · 1 comment
Closed

Make error messages of the public interface less leaky #1622

bschmalhofer opened this issue Feb 17, 2022 · 1 comment
Assignees
@bschmalhofer
Labels
security Security issues
Milestone
OTOBO 10.1.1

Comments

@bschmalhofer
Copy link
Contributor

When an unknown frontend is requested in the public interface, then a rather verbose error message is displayed. This is not reassuring, at least don't print out the @INC path. See also #1279.
@bschmalhofer bschmalhofer added the security Security issues label Feb 17, 2022
@bschmalhofer bschmalhofer added this to the OTOBO 10.1.1 milestone Feb 17, 2022
@bschmalhofer bschmalhofer self-assigned this Feb 17, 2022
bschmalhofer added a commit that referenced this issue Feb 18, 2022
@bschmalhofer
Issue #1622: add methods PublicError, PublicErrorScreen and PublicFat…
df98c90 
…alError

These methode do not print the last error and the last stacktrace.
Consistently use the new methods in the public interface
bschmalhofer added a commit that referenced this issue Feb 18, 2022
@bschmalhofer
Issue #1622: satisfy the code policy
95f99d6
bschmalhofer added a commit that referenced this issue Feb 18, 2022
@bschmalhofer
Merge pull request #1623 from RotherOSS/issue-#1622-public_pl
c358b17 
Issue #1622 public pl
@bschmalhofer
Copy link
Contributor Author

Implemented the dedicated methods PublicError(), PublicErrorScreen(), PublicFatalError(). Did some quick manual testing. Looks fine. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bschmalhofer bschmalhofer

Labels
security Security issues
Projects
None yet
Milestone
OTOBO 10.1.1
Development

No branches or pull requests
1 participant
@bschmalhofer