Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CustomerCompanySearchListLimit and CustomerUserSearchListLimit do not work in the overview pages #1539

Closed
StefanRother-OTOBO opened this issue Jan 13, 2022 · 1 comment
Assignees
Labels
bug Something isn't working as intended
Milestone

Comments

@StefanRother-OTOBO
Copy link
Contributor

CustomerCompanySearchListLimit and CustomerUserSearchListLimit do not work in the overview pages. Until now, a limit of 400 always applied here, unless Customer*SearchListLimit was smaller than 400. From now on, the value stored in the configuration also applies to the AdminCustomerUser and AdminCustomerCompany overview pages.

@StefanRother-OTOBO StefanRother-OTOBO added the bug Something isn't working as intended label Jan 13, 2022
@StefanRother-OTOBO StefanRother-OTOBO added this to the OTOBO 10.1 milestone Jan 13, 2022
@StefanRother-OTOBO StefanRother-OTOBO self-assigned this Jan 13, 2022
StefanRother-OTOBO pushed a commit that referenced this issue Jan 13, 2022
…tLimit do not work in the overview pages.
@svenoe
Copy link
Contributor

svenoe commented Jan 17, 2022

This should be changed. The $Limit here is really only used to check whether more results would be available without limit. This was not programmed really precise, but the current changes just improve a very specific case, which is one Customer backend with a large limit. Actually for the code to really work the largest limit + 1 would have to be chosen (which is impossible if no limit is defined in the map at all, where it falls back to a hardcoded 250 for Kernel/System/CustomerUser/DB.pm, to 50000 for Kernel/System/CustomerCompany/DB.pm,...), instead of the smallest + 1 and then the size of both results would have to be compared instead of a comparison to the $Limit, but we shouldn't do that for possible performance issues. Thus in my opinion we should keep it as it is and just use the hardcoded values (changed to 250 and 50000, matching their DB counterparts), if no limits are defined in any map. Thus the problem will be solved for single backends, and multiple backends might have a "more are available" erroneously shown for different limit sizes of different backends, where the smallest limit still is larger than its content, but is restricting the other backends.

@bschmalhofer bschmalhofer modified the milestones: OTOBO 10.1, OTOBO 10.1.1 Feb 2, 2022
svenoe pushed a commit that referenced this issue Feb 7, 2022
…earchListLimit do not work in the overview pages."

This reverts commit 62590ff.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as intended
Projects
None yet
Development

No branches or pull requests

3 participants