Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect message when mapping modules can't be initialized. #1524

Closed
bschmalhofer opened this issue Dec 22, 2021 · 2 comments
Closed

Incorrect message when mapping modules can't be initialized. #1524

bschmalhofer opened this issue Dec 22, 2021 · 2 comments
Assignees
@bschmalhofer
Labels
bug Something isn't working as intended
Milestone
OTOBO 10.1.1

Comments

@bschmalhofer
Copy link
Contributor

While looking into this, I noticed that there is a mixup of message for the generic interface debugger. When a mapping module can't be initialized then the error message of a previous function result is written into the debug log.
The underlying cause is the reusing of the variable $FunctionResult.

Creating an extra issue for this, as this is a bug.

Originally posted by @bschmalhofer in #1471 (comment)
@bschmalhofer bschmalhofer self-assigned this Dec 22, 2021
@bschmalhofer bschmalhofer added the bug Something isn't working as intended label Dec 22, 2021
@bschmalhofer bschmalhofer added this to the OTOBO 10.1.1 milestone Dec 22, 2021
@bschmalhofer
Copy link
Contributor Author

My impression is that the misleading debug message has been in the code since the beginning. Up to 2023-02-25 there also seems to have been an error where the non-existent method $Self->DebuggerObject() was called. See line 263 in Requester.pm in the commit znuny/Znuny@36c3732.
So I think that it is save to clean up the mess.

bschmalhofer added a commit that referenced this issue Dec 22, 2021
@bschmalhofer
Issue #1524: emit only a single error message
9a87f09 
when the mapping object could not be created.
Do not emit the empty error message from a previous function call.
bschmalhofer added a commit that referenced this issue Dec 22, 2021
@bschmalhofer
Issue #1524: use $MapResult for the result of ->Map().
c4d164f 
Reusing variable names is not a good practice.
bschmalhofer added a commit that referenced this issue Dec 22, 2021
@bschmalhofer
Issue #1524: saner name for result of PrepareRequest().
b5f2da9
bschmalhofer added a commit that referenced this issue Dec 22, 2021
@bschmalhofer
Issue #1524: saner name for result of RequesterPerformRequest()
13ae043
bschmalhofer added a commit that referenced this issue Dec 22, 2021
@bschmalhofer
Issue #1524: saner name for result of HandleResponse()
9c10be3
bschmalhofer added a commit that referenced this issue Dec 22, 2021
@bschmalhofer
Issue #1524: tidying
79518f3 
use v5.24
simplified constructor
bschmalhofer added a commit that referenced this issue Dec 22, 2021
@bschmalhofer
Merge pull request #1525 from RotherOSS/issue-#1524-mapping_debug
0726108 
Issue #1524 mapping debug
@bschmalhofer
Copy link
Contributor Author

Running the test suite showed new errors:

Test Summary Report

/opt/otobo/scripts/test/Compile.t (Wstat: 0 Tests: 1784 Failed: 0)
TODO passed: 1010, 1035
/opt/otobo/scripts/test/DynamicField/EditFieldRender.t (Wstat: 2048 Tests: 69 Failed: 8)
Failed tests: 14-21
Non-zero exit status: 8
/opt/otobo/scripts/test/Selenium/Output/Dashboard/TicketGenericFilter.t (Wstat: 256 Tests: 25 Failed: 1)
Failed test: 20
Non-zero exit status: 1
/opt/otobo/scripts/test/Selenium/TestingMethods.t (Wstat: 0 Tests: 36 Failed: 0)
TODO passed: 21, 24, 28
/opt/otobo/scripts/test/WebUserAgent.t (Wstat: 1024 Tests: 121 Failed: 4)
Failed tests: 76-77, 89, 101
Non-zero exit status: 4
Files=960, Tests=82047, 6483 wallclock secs (31.02 usr 3.18 sys + 1688.69 cusr 205.12 csys = 1928.01 CPU)
Result: FAIL
ran tests for product OTOBO 10.1.x on host 44319b0a6e0d .

However these error occur also without the changes for this issue. Thus the PR can be applied. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bschmalhofer bschmalhofer

Labels
bug Something isn't working as intended
Projects
None yet
Milestone
OTOBO 10.1.1
Development

No branches or pull requests
1 participant
@bschmalhofer