Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use Plack::Loader::SyncWitS3 when OTOBO_SYNC_WITH_S3=0 is set #1478

Closed
bschmalhofer opened this issue Dec 4, 2021 · 1 comment
Closed
Assignees
Labels
bug Something isn't working as intended
Milestone

Comments

@bschmalhofer
Copy link
Contributor

When

OTOBO_SYNC_WITH_S3=0

is set in .env then plackup uses the loader Plack::Loader::SyncWitS3. This because of a check in bin/docker/entrypoint.sh ,

# For production use Gazelle, which is implemented in C.
# The special loader Plack::Loader::SyncWithS3 checks for updates in S3.
if [[ -z "$OTOBO_SYNC_WITH_S3" ]]; then
    exec plackup --server Gazelle --env deployment --port 5000 bin/psgi-bin/otobo.psgi
else
    exec plackup --server Gazelle --env deployment --port 5000 -I /opt/otobo -I /opt/otobo/Kernel/cpan-lib --loader SyncWithS3  bin/psgi-bin/otobo.psgi
fi

It is not obvious why this hasn't been noticed before. A possibility is that the loader SyncWithS3 was always used but happened to work even when S3 was not activated.

@bschmalhofer bschmalhofer added the bug Something isn't working as intended label Dec 4, 2021
@bschmalhofer bschmalhofer added this to the OTOBO 10.1.1 milestone Dec 4, 2021
@bschmalhofer bschmalhofer self-assigned this Dec 4, 2021
bschmalhofer added a commit that referenced this issue Dec 4, 2021
…ut_zero

Issue #1478: explicitly consider $OTOBO_SYNC_WITH_S3=0
@bschmalhofer
Copy link
Contributor Author

The service web now starts up again just fine. Test suite looks good. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as intended
Projects
None yet
Development

No branches or pull requests

1 participant