Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency on Plack::Middleware::ForceEnv #1316

Closed
bschmalhofer opened this issue Oct 13, 2021 · 2 comments
Closed

Remove dependency on Plack::Middleware::ForceEnv #1316

bschmalhofer opened this issue Oct 13, 2021 · 2 comments
Assignees
@bschmalhofer
Labels
tidying Tidying of the code
Milestone
OTOBO 10.1.1

Comments

@bschmalhofer
Copy link
Contributor

The usage of Plack::Middleware::ForceEnv in otobo.psgi looks very wrong. The middleware injects settings in the PSGI variable $Env, not into the system environmen %ENV. The middleware is also only used for rpc.pl, so any strangeness went propably unnoticed.
@bschmalhofer bschmalhofer added the tidying Tidying of the code label Oct 13, 2021
@bschmalhofer bschmalhofer added this to the OTOBO 10.1.1 milestone Oct 13, 2021
@bschmalhofer bschmalhofer self-assigned this Oct 13, 2021
@bschmalhofer
Copy link
Contributor Author

While we are at it. the environment variable OTOBO_RUNS_UNDER_PSGI can be eliminated too. There are only two use cases active.

  • SupportDataCollector
  • activating DBIx::Connector in Kernel::System::DB

It looks like both cases can be handled with the env variable GATEWAY_INTERFACE.

bschmalhofer added a commit that referenced this issue Oct 14, 2021
@bschmalhofer
Issue #1316: update code comments and POD
582895a
bschmalhofer added a commit that referenced this issue Oct 14, 2021
@bschmalhofer
Issue #1316: solely use GATEWAY_INTERFACE for indicating web context
1deeaa0
bschmalhofer added a commit that referenced this issue Oct 14, 2021
@bschmalhofer
Issue #1316: use a better name for response with code 500
28d48b2
bschmalhofer added a commit that referenced this issue Oct 14, 2021
@bschmalhofer
Issue #1316: use postfix 'unless', for consistencies sake
a10dc34
bschmalhofer added a commit that referenced this issue Oct 14, 2021
@bschmalhofer
Issue #1316: do not use Plack::Middleware::ForceEnv
2c01f3c
bschmalhofer added a commit that referenced this issue Oct 14, 2021
@bschmalhofer
Issue #1316: update the bucket to the currently used value
915c058 
even though this is unrelated to ForceEnv
bschmalhofer added a commit that referenced this issue Oct 14, 2021
@bschmalhofer
Merge pull request #1323 from RotherOSS/issue-#1316-get_rid_of_forceenv
f079318 
Issue #1316 get rid of forceenv
@bschmalhofer
Copy link
Contributor Author

Plack::Middlware::ForceEnv is removed. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bschmalhofer bschmalhofer

Labels
tidying Tidying of the code
Projects
None yet
Milestone
OTOBO 10.1.1
Development

No branches or pull requests
1 participant
@bschmalhofer