Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove references to CGI modules in otobo.psgi #1136

Closed
bschmalhofer opened this issue Jul 16, 2021 · 2 comments
Closed

Remove references to CGI modules in otobo.psgi #1136

bschmalhofer opened this issue Jul 16, 2021 · 2 comments
Assignees
@bschmalhofer
Labels
tidying Tidying of the code
Milestone
OTOBO 10.1.1

Comments

@bschmalhofer
Copy link
Contributor

bschmalhofer commented Jul 16, 2021 •
edited
Loading

There is still some support for CGI.pm like objects in OTOBO 10.0.x. But that is mostly useful during testing. otobo.psgi and Kernel::System::Web::Request should not explicitly need any modules in the CGI namespace, with the exception CGI::PSGI. Let's try to eliminate them.
@bschmalhofer bschmalhofer added the tidying Tidying of the code label Jul 16, 2021
@bschmalhofer bschmalhofer added this to the OTOBO 10.1 milestone Jul 16, 2021
@bschmalhofer bschmalhofer self-assigned this Jul 16, 2021
@bschmalhofer
Copy link
Contributor Author

bschmalhofer commented Jul 16, 2021 •
edited
Loading

A special case is the support for $CGI::POST_MAX in Kernel::System::Web::Request. This variable limits the POST size to the value of $ConfigObject->Get('WebMaxFileUpload') || 1024 * 1024 * 5. It needs to be checked whether this setting is handled be CGI::PSGI in the same way as CGI.pm did in OTOBO 10.0.x without PSGI.

@bschmalhofer bschmalhofer mentioned this issue Jul 16, 2021
Closed
bschmalhofer added a commit that referenced this issue Nov 4, 2021
@bschmalhofer
Issue #1136: enhance the POD
95120be 
Let the POD reflect actual usage.
Added some code tags.
bschmalhofer added a commit that referenced this issue Nov 4, 2021
@bschmalhofer
Issue #1136: load CGI::PSGI only where it is actually used
2e4987e
bschmalhofer added a commit that referenced this issue Nov 4, 2021
@bschmalhofer
Issue #1136: Calling CGI->compile() was useless
eabe03c 
As CGI->compile() is a noop in CGI 4.36, which is the version of Kernel/cpan-lib/CGI.pm
bschmalhofer added a commit that referenced this issue Nov 4, 2021
@bschmalhofer
Issue #1136: no need to call CGI::initialize_globals()
40c14dc 
as this is done already in CGI::PSGI::new().
This there is no reason any more for loading the module CGI.
bschmalhofer added a commit that referenced this issue Nov 4, 2021
@bschmalhofer
Merge pull request #1383 from RotherOSS/issue-#1136-CGI_modules
4bcf2cf 
Issue #1136 cgi modules
@bschmalhofer
Copy link
Contributor Author

Checked the code and made some small improvements. Test suite still looks fine. Closing this issue.

@bschmalhofer bschmalhofer modified the milestones: OTOBO 10.1, OTOBO 10.1.1 Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bschmalhofer bschmalhofer

Labels
tidying Tidying of the code
Projects
None yet
Milestone
OTOBO 10.1.1
Development

No branches or pull requests
1 participant
@bschmalhofer