Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend using cpanm in otobo.CheckModules.pl #1057

Closed
bschmalhofer opened this issue Jun 6, 2021 · 1 comment
Closed

Recommend using cpanm in otobo.CheckModules.pl #1057

bschmalhofer opened this issue Jun 6, 2021 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@bschmalhofer
Copy link
Contributor

Currently bin/otobo.CheckModules.pl -list emits the following for a missing module:

o Archive::Tarx...................Not installed! To install, you can use: 'cpan Archive::Tarxx'. (required - Required for compressed file ge
neration (in perlcore).)

I propose to change cpan to cpanm because cpanm is much less hassle.

@bschmalhofer bschmalhofer added the enhancement New feature or request label Jun 6, 2021
@bschmalhofer bschmalhofer added this to the OTOBO 10.1 milestone Jun 6, 2021
@bschmalhofer bschmalhofer changed the title Recomment using cpanm in otobo.CheckModules.pl Recommend using cpanm in otobo.CheckModules.pl Jun 6, 2021
bschmalhofer added a commit that referenced this issue Sep 30, 2021
bschmalhofer added a commit that referenced this issue Sep 30, 2021
@bschmalhofer
Copy link
Contributor Author

bschmalhofer commented Sep 30, 2021

Change the default command. Tested by adding a dummy module that is not installed yet.

bes:~/devel/OTOBO/otobo (issue-#1057-cpanm)$ git diff
diff --git a/bin/otobo.CheckModules.pl b/bin/otobo.CheckModules.pl
index 51b37b8689..122086c909 100755
--- a/bin/otobo.CheckModules.pl
+++ b/bin/otobo.CheckModules.pl
@@ -276,6 +276,13 @@ my $ExitCode = 0; # success
my @NeededModules = (

 # Core

+ {
+ Module => 'Acme::Pi',
+ Required => 1,
+ Comment => 'test',
+ InstTypes => {
+ },
+ },
{
Module => 'Archive::Tar',
Required => 1,
bes:~/devel/OTOBO/otobo (issue-#1057-cpanm)$ bin/otobo.CheckModules.pl -l | grep Pi
o Acme::Pi.........................Not installed! To install, you can use: 'cpanm Acme::Pi'. (required - test)
bes:~/devel/OTOBO/otobo (issue-#1057-cpanm)$

Looking good. PR is merged. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant