Issue #2842: Fixed iterations over hash keys instead of hash in df se…

…t driver.
RotherOSS · Feb 23, 2024 · f588863 · f588863
1 parent c0a2b2f
commit f588863
Showing 1 changed file with 11 additions and 11 deletions.
diff --git a/Kernel/System/DynamicField/Driver/Set.pm b/Kernel/System/DynamicField/Driver/Set.pm
@@ -186,7 +186,7 @@ sub ValueValidate {
 
     return if !$DynamicField;
 
-    for my $Name ( $DynamicField->%* ) {
+    for my $Name ( sort keys $DynamicField->%* ) {
         for my $SetIndex ( 0 .. $#SetValue ) {
 
             return if !$BackendObject->ValueValidate(
@@ -256,7 +256,7 @@ sub EditFieldRender {
     return if !$DynamicField;
 
     DYNAMICFIELD:
-    for my $Name ( keys $DynamicField->%* ) {
+    for my $Name ( sort keys $DynamicField->%* ) {
         if ( !IsHashRefWithData( $DynamicField->{$Name} ) ) {
             delete $DynamicField->{$Name};
 
@@ -286,7 +286,7 @@ sub EditFieldRender {
 
     for my $SetIndex ( 0 .. $#SetValue ) {
         my %Value;
-        for my $Name ( keys $DynamicField->%* ) {
+        for my $Name ( sort keys $DynamicField->%* ) {
             $Value{"DynamicField_$Name"} = $SetValue[$SetIndex]{$Name};
             $DynamicField->{$Name}{Name} = $Name . '_' . $SetIndex;
         }
@@ -323,7 +323,7 @@ sub EditFieldRender {
     # decide which structure to return
     # decide which structure to return
     if ( $FieldConfig->{MultiValue} ) {
-        for my $Name ( keys $DynamicField->%* ) {
+        for my $Name ( sort keys $DynamicField->%* ) {
             $DynamicField->{$Name}{Name} = $Name . '_Template';
         }
 
@@ -392,7 +392,7 @@ sub EditFieldValueGet {
     return if !$DynamicField;
 
     DYNAMICFIELD:
-    for my $Name ( keys $DynamicField->%* ) {
+    for my $Name ( sort keys $DynamicField->%* ) {
         if ( !IsHashRefWithData( $DynamicField->{$Name} ) ) {
             delete $DynamicField->{$Name};
 
@@ -403,7 +403,7 @@ sub EditFieldValueGet {
         $DynamicField->{$Name} = { $DynamicField->{$Name}->%* };
     }
 
-    for my $Name ( keys $DynamicField->%* ) {
+    for my $Name ( sort keys $DynamicField->%* ) {
         my $DynamicFieldConfig = $DynamicField->{$Name};
 
         for my $SetIndex ( 0 .. $IndexMax ) {
@@ -447,7 +447,7 @@ sub EditFieldValueValidate {
     return 1 if !$DynamicField;
 
     DYNAMICFIELD:
-    for my $Name ( keys $DynamicField->%* ) {
+    for my $Name ( sort keys $DynamicField->%* ) {
         if ( !IsHashRefWithData( $DynamicField->{$Name} ) ) {
             delete $DynamicField->{$Name};
 
@@ -458,7 +458,7 @@ sub EditFieldValueValidate {
         $DynamicField->{$Name} = { $DynamicField->{$Name}->%* };
     }
 
-    for my $Name ( keys $DynamicField->%* ) {
+    for my $Name ( sort keys $DynamicField->%* ) {
         my $DynamicFieldConfig = $DynamicField->{$Name};
 
         for my $SetIndex ( 0 .. $IndexMax ) {
@@ -664,7 +664,7 @@ sub RandomValueSet {
 
     return { Success => 0 } if !$DynamicField;
 
-    for my $Name ( keys $DynamicField->%* ) {
+    for my $Name ( sort keys $DynamicField->%* ) {
         my $DynamicFieldConfig = $DynamicField->{$Name};
 
         my $Return = $BackendObject->RandomValueSet(
@@ -760,7 +760,7 @@ sub GetFieldState {
     my %Return;
 
     for my $SetIndex ( 0 .. $#SetValue ) {
-        for my $Name ( $DynamicField->%* ) {
+        for my $Name ( sort keys $DynamicField->%* ) {
             $DFParam{"DynamicField_$Name"} = $SetValue[$SetIndex]{$Name};
         }
 
@@ -798,7 +798,7 @@ sub GetFieldState {
     }
 
     if ( $SetConfig->{Config}{MultiValue} ) {
-        for my $Name ( $DynamicField->%* ) {
+        for my $Name ( sort keys $DynamicField->%* ) {
             $DFParam{"DynamicField_$Name"} = undef;
         }