Issue #838: Cleanup and CodePolicy before making real changes

RotherOSS · Mar 4, 2021 · 78ca562 · 78ca562
1 parent 5002393
commit 78ca562
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 9 deletions.
diff --git a/Kernel/System/MigrateFromOTRS.pm b/Kernel/System/MigrateFromOTRS.pm
@@ -18,13 +18,18 @@ package Kernel::System::MigrateFromOTRS;
 
 use strict;
 use warnings;
+use v5.24;
+use namespace::autoclean;
+use utf8;
 
-#use Kernel::System::VariableCheck qw(IsHashRefWithData);
+# core modules
+
+# CPAN modules
+
+# OTOBO modules
 
 our @ObjectDependencies = (
-    'Kernel::System::Cache',
     'Kernel::System::Main',
-    'Kernel::System::SysConfig',
     'Kernel::System::MigrateFromOTRS::Base',
     'Kernel::System::Log',
 );
@@ -47,10 +52,7 @@ sub new {
     my ( $Type, %Param ) = @_;
 
     # allocate new hash for object
-    my $Self = {};
-    bless( $Self, $Type );
-
-    return $Self;
+    return bless {}, $Type;
 }
 
 =head2 Run()

diff --git a/Kernel/System/MigrateFromOTRS/CloneDB/Driver/Base.pm b/Kernel/System/MigrateFromOTRS/CloneDB/Driver/Base.pm
@@ -588,7 +588,7 @@ sub DataTransfer {
 
             # drop foreign keys in the source
             my $SourceForeignKeySth = $TargetDBObject->{dbh}->foreign_key_info(
-                undef, undef, undef,
+                undef, undef,         undef,
                 undef, $SourceSchema, $SourceTable
             );
 
@@ -613,7 +613,7 @@ sub DataTransfer {
             # readd foreign keys in the target
             $TargetAddForeignKeysClauses{$TargetTable} //= [];
             my $TargetForeignKeySth = $TargetDBObject->{dbh}->foreign_key_info(
-                undef, undef, undef,
+                undef, undef,         undef,
                 undef, $TargetSchema, $TargetTable
             );