Issue #4146: Small improvement by omitting unnecessary check.

RotherOSS · Feb 20, 2025 · 665d44b · 665d44b
1 parent b96a835
commit 665d44b
Showing 1 changed file with 7 additions and 11 deletions.
diff --git a/Kernel/Modules/AdminDynamicFieldText.pm b/Kernel/Modules/AdminDynamicFieldText.pm
@@ -1065,20 +1065,16 @@ sub _ShowScreen {
     }
     elsif ( $Param{CloneFieldID} && IsArrayRefWithData( $Param{RegExList} ) ) {
 
-        if ( !$Param{RegExCounter} ) {
-
-            my $RegExCounter = 0;
-            for my $RegEx ( @{ $Param{RegExList} } ) {
+        my $RegExCounter = 0;
+        for my $RegEx ( @{ $Param{RegExList} } ) {
 
-                $RegExCounter++;
-                $Param{ 'RegEx_' . $RegExCounter }                     = $RegEx->{Value};
-                $Param{ 'CustomerRegExErrorMessage_' . $RegExCounter } = $RegEx->{ErrorMessage};
-            }
-
-            $Param{RegExCounter} = $RegExCounter;
+            $RegExCounter++;
+            $Param{ 'RegEx_' . $RegExCounter }                     = $RegEx->{Value};
+            $Param{ 'CustomerRegExErrorMessage_' . $RegExCounter } = $RegEx->{ErrorMessage};
         }
 
-        # NOTE check is necessary because previous block potentially alters $Param{RegExCounter}
+        $Param{RegExCounter} = $RegExCounter;
+
         if ( $Param{RegExCounter} ) {
 
             REGEXENTRY: