Issue #3031: Added explanatory comments and tidied code.

RotherOSS · Feb 22, 2024 · 6418d67 · 6418d67
1 parent c744e7a
commit 6418d67
Show file tree

Hide file tree

Showing 10 changed files with 40 additions and 23 deletions.
diff --git a/Kernel/Modules/AgentTicketActionCommon.pm b/Kernel/Modules/AgentTicketActionCommon.pm
@@ -913,8 +913,10 @@ sub Run {
                     DynamicFieldConfig   => $DynamicFieldConfig,
                     PossibleValuesFilter => $PossibleValuesFilter,
                     ParamObject          => $ParamObject,
-                    Mandatory            => $DynamicFieldConfig->{Mandatory},
-                    GetParam             => {
+
+                    # Mandatory is added to the configs by $Self->new
+                    Mandatory => $DynamicFieldConfig->{Mandatory},
+                    GetParam  => {
                         %GetParam,
                         CustomerUserID => $Ticket{CustomerUserID},
                         TicketID       => $Self->{TicketID},

diff --git a/Kernel/Modules/AgentTicketCompose.pm b/Kernel/Modules/AgentTicketCompose.pm
@@ -899,8 +899,10 @@ sub Run {
                 DynamicFieldConfig   => $DynamicFieldConfig,
                 PossibleValuesFilter => $PossibleValuesFilter,
                 ParamObject          => $ParamObject,
-                Mandatory            => $DynamicFieldConfig->{Mandatory},
-                GetParam             => {
+
+                # Mandatory is added to the configs by $Self->new
+                Mandatory => $DynamicFieldConfig->{Mandatory},
+                GetParam  => {
                     %GetParam,
                     CustomerUserID => $Ticket{CustomerUserID},
                     TicketID       => $Self->{TicketID},

diff --git a/Kernel/Modules/AgentTicketEmail.pm b/Kernel/Modules/AgentTicketEmail.pm
@@ -1445,8 +1445,10 @@ sub Run {
                     DynamicFieldConfig   => $DynamicFieldConfig,
                     PossibleValuesFilter => $PossibleValuesFilter,
                     ParamObject          => $ParamObject,
-                    Mandatory            => $DynamicFieldConfig->{Mandatory},
-                    GetParam             => {
+
+                    # Mandatory is added to the configs by $Self->new
+                    Mandatory => $DynamicFieldConfig->{Mandatory},
+                    GetParam  => {
                         %GetParam,
                         CustomerUserID => $CustomerUser,
                         TicketID       => $Self->{TicketID},

diff --git a/Kernel/Modules/AgentTicketEmailOutbound.pm b/Kernel/Modules/AgentTicketEmailOutbound.pm
@@ -1155,9 +1155,10 @@ sub SendEmail {
             DynamicFieldConfig   => $DynamicFieldConfig,
             PossibleValuesFilter => $PossibleValuesFilter,
             ParamObject          => $ParamObject,
-            Mandatory            =>
-                $DynamicFieldConfig->{Mandatory},
-            GetParam => {
+
+            # Mandatory is added to the configs by $Self->new
+            Mandatory => $DynamicFieldConfig->{Mandatory},
+            GetParam  => {
                 %GetParam,
                 CustomerUserID => $Ticket{CustomerUserID},
                 TicketID       => $Self->{TicketID},

diff --git a/Kernel/Modules/AgentTicketForward.pm b/Kernel/Modules/AgentTicketForward.pm
@@ -1042,8 +1042,10 @@ sub SendEmail {
             DynamicFieldConfig   => $DynamicFieldConfig,
             PossibleValuesFilter => $PossibleValuesFilter,
             ParamObject          => $ParamObject,
-            Mandatory            => $DynamicFieldConfig->{Mandatory},
-            GetParam             => {
+
+            # Mandatory is added to the configs by $Self->new
+            Mandatory => $DynamicFieldConfig->{Mandatory},
+            GetParam  => {
                 %GetParam,
                 CustomerUserID => $Ticket{CustomerUserID},
                 TicketID       => $Self->{TicketID},

diff --git a/Kernel/Modules/AgentTicketMove.pm b/Kernel/Modules/AgentTicketMove.pm
@@ -80,7 +80,6 @@ sub new {
                 Mandatory => $Config->{DynamicField}{ $DynamicField->{Name} } == 2 ? 1 : 0,
             };
 
-            # TODO check if this persists
             if ( $Config->{DynamicField}{ $DynamicField->{Name} } == 2 ) {
                 $DynamicField->{Mandatory} = 1;
             }
@@ -883,8 +882,10 @@ sub Run {
                 DynamicFieldConfig   => $DynamicFieldConfig,
                 PossibleValuesFilter => $PossibleValuesFilter,
                 ParamObject          => $ParamObject,
-                Mandatory            => $DynamicFieldConfig->{Mandatory},
-                GetParam             => {
+
+                # Mandatory is added to the configs by $Self->new
+                Mandatory => $DynamicFieldConfig->{Mandatory},
+                GetParam  => {
                     %GetParam,
                     CustomerUserID => $Ticket{CustomerUserID},
                     TicketID       => $Self->{TicketID},

diff --git a/Kernel/Modules/AgentTicketPhone.pm b/Kernel/Modules/AgentTicketPhone.pm
@@ -1262,8 +1262,10 @@ sub Run {
                     DynamicFieldConfig   => $DynamicFieldConfig,
                     PossibleValuesFilter => $PossibleValuesFilter,
                     ParamObject          => $ParamObject,
-                    Mandatory            => $DynamicFieldConfig->{Mandatory},
-                    GetParam             => {
+
+                    # Mandatory is added to the configs by $Self->new
+                    Mandatory => $DynamicFieldConfig->{Mandatory},
+                    GetParam  => {
                         %GetParam,
                         CustomerUserID => $CustomerUser,
                         TicketID       => $Self->{TicketID},

diff --git a/Kernel/Modules/AgentTicketPhoneCommon.pm b/Kernel/Modules/AgentTicketPhoneCommon.pm
@@ -82,7 +82,6 @@ sub new {
                 Mandatory => $Config->{DynamicField}{ $DynamicField->{Name} } == 2 ? 1 : 0,
             };
 
-            # TODO check if this persists
             if ( $Config->{DynamicField}{ $DynamicField->{Name} } == 2 ) {
                 $DynamicField->{Mandatory} = 1;
             }
@@ -741,8 +740,10 @@ sub Run {
                 DynamicFieldConfig   => $DynamicFieldConfig,
                 PossibleValuesFilter => $PossibleValuesFilter,
                 ParamObject          => $ParamObject,
-                Mandatory            => $DynamicFieldConfig->{Mandatory},
-                GetParam             => {
+
+                # Mandatory is added to the configs by $Self->new
+                Mandatory => $DynamicFieldConfig->{Mandatory},
+                GetParam  => {
                     %GetParam,
                     CustomerUserID => $Ticket{CustomerUserID},
                     TicketID       => $Self->{TicketID},

diff --git a/Kernel/Modules/CustomerTicketMessage.pm b/Kernel/Modules/CustomerTicketMessage.pm
@@ -671,8 +671,10 @@ sub Run {
                     DynamicFieldConfig   => $DynamicFieldConfig,
                     PossibleValuesFilter => $PossibleValuesFilter,
                     ParamObject          => $ParamObject,
-                    Mandatory            => $DynamicFieldConfig->{Mandatory},
-                    Getparam             => {
+
+                    # Mandatory is added to the configs by $Self->new
+                    Mandatory => $DynamicFieldConfig->{Mandatory},
+                    Getparam  => {
                         %GetParam,
                         CustomerUserID => $Self->{UserID},
                         TicketID       => $Self->{TicketID},

diff --git a/Kernel/Modules/CustomerTicketZoom.pm b/Kernel/Modules/CustomerTicketZoom.pm
@@ -967,8 +967,10 @@ sub Run {
                     DynamicFieldConfig   => $DynamicFieldConfig,
                     PossibleValuesFilter => $PossibleValuesFilter,
                     ParamObject          => $ParamObject,
-                    Mandatory            => $DynamicFieldConfig->{Mandatory},
-                    GetParam             => {
+
+                    # Mandatory is added to the configs by $Self->new
+                    Mandatory => $DynamicFieldConfig->{Mandatory},
+                    GetParam  => {
                         %GetParam,
                         CustomerUserID => $Self->{UserID},
                         TicketID       => $Ticket{TicketID},