Merge pull request #1253 from RotherOSS/issue-#1147-IsPackageDownload…

…able Issue #1147 is package downloadable
RotherOSS · Sep 23, 2021 · 1b71c2f · 1b71c2f
2 parents 362e9e4 + 16e32a4
commit 1b71c2f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/Kernel/Modules/AdminPackageManager.pm b/Kernel/Modules/AdminPackageManager.pm
@@ -254,6 +254,7 @@ sub Run {
         PACKAGEACTION:
         for my $PackageAction (qw(DownloadLocal Rebuild Reinstall)) {
 
+            # provide local download button on when the package allows it
             if (
                 $PackageAction eq 'DownloadLocal'
                 && (
@@ -431,7 +432,7 @@ sub Run {
                             },
                         );
 
-                        # check if is possible to download files
+                        # check whether it is allowed to download files
                         if (
                             !defined $Structure{PackageIsDownloadable}
                             || (
@@ -574,7 +575,7 @@ sub Run {
             Data => { %Param, %Frontend, },
         );
 
-        # allow to download only if package is allow to do it
+        # provide remote download button only when the package allows it
         if (
             !defined $Structure{PackageIsDownloadable}
             || (
@@ -732,7 +733,7 @@ sub Run {
                             },
                         );
 
-                        # check if is possible to download files
+                        # check whether it is allowed to download files
                         if (
                             !defined $Structure{PackageIsDownloadable}
                             || (

diff --git a/Kernel/System/Console/Command/Dev/Package/Build.pm b/Kernel/System/Console/Command/Dev/Package/Build.pm
@@ -104,13 +104,14 @@ sub Run {
         String => $FileString,
     );
 
-    # just build it if PackageIsDownloadable flag is enable
+    # Don't build the opm if the PackageIsDownloadable flag is explicitly disabled.
     if (
         defined $Structure{PackageIsDownloadable}
         && !$Structure{PackageIsDownloadable}->{Content}
         )
     {
-        $Self->PrintError("Package cannot be built.\n");
+        $Self->PrintError("Package is not built because the flag PackageIsDownloadable is set to 0.\n");
+
         return $Self->ExitCodeError();
     }