Add inv(::AbstractQ) (JuliaLang#35826)

* Override `inv` for `AbstractQ` * Add test for inv * Update qr.jl Co-authored-by: Andreas Noack <[email protected]>
Roger-luo · May 14, 2020 · a6fe51a · a6fe51a
1 parent 00154da
commit a6fe51a
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/stdlib/LinearAlgebra/src/qr.jl b/stdlib/LinearAlgebra/src/qr.jl
@@ -467,6 +467,8 @@ Base.propertynames(F::QRPivoted, private::Bool=false) =
 
 abstract type AbstractQ{T} <: AbstractMatrix{T} end
 
+inv(Q::AbstractQ) = Q'
+
 """
     QRPackedQ <: AbstractMatrix
 

diff --git a/stdlib/LinearAlgebra/test/qr.jl b/stdlib/LinearAlgebra/test/qr.jl
@@ -297,4 +297,11 @@ end
     end
 end
 
+@testset "inv(::AbstractQ)" begin
+    for T in (Float64, ComplexF64)
+        Q = qr(randn(T,5,5)).Q
+        @test inv(Q) === Q'
+    end
+end
+
 end # module TestQR
-Original file line number
+Diff line change
@@ Expand Up / @@ -467,6 +467,8 @@ Base.propertynames(F::QRPivoted, private::Bool=false) = @@
     abstract type AbstractQ{T} <: AbstractMatrix{T} end
+    inv(Q::AbstractQ) = Q'
     """
         QRPackedQ <: AbstractMatrix
@@ Expand Down @@