Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ability to exclude assemblies from resoltion via attribute as w… #1432

Merged
merged 1 commit into from
Dec 29, 2024
Merged

Added ability to exclude assemblies from resoltion via attribute as w… #1432

merged 1 commit into from
Dec 29, 2024

Conversation

david-driscoll
Copy link
Member

…ell as via build property

@github-actions github-actions bot added this to the v13.0.0 milestone Dec 29, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 29, 2024 •
edited
Loading

Test Results

    3 files  ±0      3 suites  ±0   1h 18m 48s ⏱️ + 13m 35s
  670 tests ±0    668 ✅ ±0  2 💤 ±0  0 ❌ ±0 
1 132 runs  ±0  1 128 ✅ ±0  4 💤 ±0  0 ❌ ±0 

Results for commit b113380. ± Comparison against base commit a9e3122.

♻️ This comment has been updated with latest results.

@david-driscoll david-driscoll force-pushed the simplify-cache-and-reduce-scanned-sassa branch from ad986f1 to e85bf22 Compare December 29, 2024 07:40
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 29, 2024 •
edited
Loading

Summary

Summary
Generated on: 12/29/2024 - 08:02:06
Coverage date: 12/29/2024 - 08:02:04
Parser: Cobertura
Assemblies: 6
Classes: 128
Files: 102
Line coverage: 75.5% (3983 of 5270)
Covered lines: 3983
Uncovered lines: 1287
Coverable lines: 5270
Total lines: 10491
Branch coverage: 68.7% (1355 of 1970)
Covered branches: 1355
Total branches: 1970
Method coverage: Feature is only available for sponsors
Tag: 13.0.0-pr1432.175+Branch.pull-1432-merge.Sha.3c4af3212b68109369578d6742c4fcc34e8e82e3

Coverage

Rocket.Surgery.DependencyInjection.Analyzers - 90.3%
Name Line Branch
Rocket.Surgery.DependencyInjection.Analyzers 90.3% 80.8%
Rocket.Surgery.DependencyInjection.Analyzers.AnyTypeData 100%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyCollection 71.4% 85.1%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyCollection.Item 100%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyCollectionData 100%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyFilterData 100%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviderBuilder 100% 95.8%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviderConfiguration 96.2% 87.7%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviders.AlwaysMatchT
ypeFilter		 0%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviders.CompiledAsse
mblyFilter		 97% 50%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviders.CompiledServ
iceTypeDescriptors		 28.5% 100%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviders.CompiledType
Filter		 100% 91.6%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviders.DataHelpers 95.8% 75.1%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviders.FindTypeInAs
sembly		 100%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviders.FindTypeVisi
tor		 100% 100%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviders.MustBeAnExpr
essionException		 100%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviders.TypeSymbolVi
sitor		 100%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviders.TypeSymbolVi
sitorBase		 100% 80%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviders.TypeSymbolVi
sitorExtensions		 21% 0%
Rocket.Surgery.DependencyInjection.Analyzers.AssignableToAnyTypeData 100%
Rocket.Surgery.DependencyInjection.Analyzers.AssignableToTypeData 100%
Rocket.Surgery.DependencyInjection.Analyzers.CompiledAssemblyProviderData 100% 100%
Rocket.Surgery.DependencyInjection.Analyzers.CompiledServiceScanningGenerat
or		 100% 100%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.AllAssemblyDescrip
tor		 0%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.AssemblyDependenci
esDescriptor		 50%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.AssemblyDescriptor 50%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.AssignableToAnyTyp
eFilterDescriptor		 100%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.AssignableToTypeFi
lterDescriptor		 100%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.CompiledServiceTyp
eDescriptor		 100%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.ImplementedInterfa
cesServiceTypeDescriptor		 100%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.IncludeSystemAssem
bliesDescriptor		 0%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.NameFilterDescript
or		 100%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.NamespaceFilterDes
criptor		 100%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.NotAssemblyDescrip
tor		 50%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.NotAssignableToAny
TypeFilterDescriptor		 0%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.NotAssignableToTyp
eFilterDescriptor		 100%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.TypeInfoFilterDesc
riptor		 100%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.TypeKindFilterDesc
riptor		 100%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.WithAnyAttributeFi
lterDescriptor		 100%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.WithAnyAttributeSt
ringFilterDescriptor		 0%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.WithAttributeFilte
rDescriptor		 100%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.WithAttributeStrin
gFilterDescriptor		 0%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.WithoutAttributeFi
lterDescriptor		 100%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.WithoutAttributeSt
ringFilterDescriptor		 0%
Rocket.Surgery.DependencyInjection.Analyzers.Diagnostics 100%
Rocket.Surgery.DependencyInjection.Analyzers.GetAssemblyConfiguration 100%
Rocket.Surgery.DependencyInjection.Analyzers.GetReflectionCollectionData 100%
Rocket.Surgery.DependencyInjection.Analyzers.GetServiceDescriptorCollection
Data		 100%
Rocket.Surgery.DependencyInjection.Analyzers.Helpers 78.3% 65.2%
Rocket.Surgery.DependencyInjection.Analyzers.NameFilterData 100%
Rocket.Surgery.DependencyInjection.Analyzers.NamespaceFilterData 100%
Rocket.Surgery.DependencyInjection.Analyzers.ReflectionCollection 76.5% 100%
Rocket.Surgery.DependencyInjection.Analyzers.ReflectionCollection.Item 100%
Rocket.Surgery.DependencyInjection.Analyzers.ReflectionCollectionData 100%
Rocket.Surgery.DependencyInjection.Analyzers.ResolvedSourceLocation 100%
Rocket.Surgery.DependencyInjection.Analyzers.SavedSourceLocation 100%
Rocket.Surgery.DependencyInjection.Analyzers.ServiceDescriptorCollection 87.8% 82.9%
Rocket.Surgery.DependencyInjection.Analyzers.ServiceDescriptorCollection.It
em		 100%
Rocket.Surgery.DependencyInjection.Analyzers.ServiceDescriptorCollectionDat
a		 100%
Rocket.Surgery.DependencyInjection.Analyzers.ServiceDescriptorFilterData 100%
Rocket.Surgery.DependencyInjection.Analyzers.ServiceTypeData 100%
Rocket.Surgery.DependencyInjection.Analyzers.SourceLocation 100%
Rocket.Surgery.DependencyInjection.Analyzers.StatementGeneration 89.8% 77.7%
Rocket.Surgery.DependencyInjection.Analyzers.SwitchGenerator 96.5% 88.2%
Rocket.Surgery.DependencyInjection.Analyzers.TypeFilterData 100%
Rocket.Surgery.DependencyInjection.Analyzers.TypeInfoFilterData 100%
Rocket.Surgery.DependencyInjection.Analyzers.TypeKindFilterData 100%
Rocket.Surgery.DependencyInjection.Analyzers.WithAttributeData 100%
Rocket.Surgery.DependencyInjection.Analyzers.WithAttributeStringData 0%
Rocket.Surgery.DependencyInjection.Extensions - 78.7%
Name Line Branch
Rocket.Surgery.DependencyInjection.Extensions 78.7% 48.2%
Rocket.Surgery.DependencyInjection.Compiled.CompiledTypeProviderAttribute 75%
Rocket.Surgery.DependencyInjection.Compiled.CompiledTypeProviderExtensions 100% 50%
Rocket.Surgery.DependencyInjection.Compiled.ExcludeFromCompiledTypeProvider
Attribute		 0%
Rocket.Surgery.DependencyInjection.Compiled.ICompiledTypeProvider 0% 0%
Rocket.Surgery.DependencyInjection.ExecuteScoped 80.9% 50%
Rocket.Surgery.DependencyInjection.ExecuteScoped<T1, T2, T3, T4, T5, T6> 93.3% 50%
Rocket.Surgery.DependencyInjection.ExecuteScoped<T1, T2, T3, T4, T5> 88.8% 50%
Rocket.Surgery.DependencyInjection.ExecuteScoped<T1, T2, T3, T4> 88.2% 50%
Rocket.Surgery.DependencyInjection.ExecuteScoped<T1, T2, T3> 87.5% 50%
Rocket.Surgery.DependencyInjection.ExecuteScoped<T1, T2> 86.6% 50%
Rocket.Surgery.DependencyInjection.ExecuteScopedOptional 80.9% 50%
Rocket.Surgery.DependencyInjection.ExecuteScopedOptional<T1, T2, T3, T4, T5
, T6>		 93.3% 50%
Rocket.Surgery.DependencyInjection.ExecuteScopedOptional<T1, T2, T3, T4, T5
>		 88.8% 50%
Rocket.Surgery.DependencyInjection.ExecuteScopedOptional<T1, T2, T3, T4> 88.2% 50%
Rocket.Surgery.DependencyInjection.ExecuteScopedOptional<T1, T2, T3> 87.5% 50%
Rocket.Surgery.DependencyInjection.ExecuteScopedOptional<T1, T2> 86.6% 50%
Rocket.Surgery.DependencyInjection.RegistrationLifetimeAttribute 0%
Rocket.Surgery.DependencyInjection.ScopedServiceExtensions 50%
Rocket.Surgery.DependencyInjection.ScopedServiceOptionalExtensions 50%
Rocket.Surgery.DependencyInjection.ServiceRegistrationAttribute 0%
Rocket.Surgery.DependencyInjection.ServiceRegistrationAttribute 0%
Rocket.Surgery.DependencyInjection.ServiceRegistrationAttribute<TService1,
TService2, TService3, TService4>		 0%
Rocket.Surgery.DependencyInjection.ServiceRegistrationAttribute<TService1,
TService2, TService3>		 0%
Rocket.Surgery.DependencyInjection.ServiceRegistrationAttribute<TService1,
TService2>		 0%
Rocket.Surgery.Extensions - 74.7%
Name Line Branch
Rocket.Surgery.Extensions 74.7% 71%
Rocket.Surgery.Extensions.Encoding.Base3264Encoding 93.7% 85.7%
Rocket.Surgery.Extensions.Encoding.Base32Url 79.1% 79.5%
Rocket.Surgery.Extensions.Encoding.Base32Url.CharMap 46.6% 62.5%
Rocket.Surgery.Extensions.Encoding.Base64Url 80% 66.6%
Rocket.Surgery.Extensions.NullableExtensions 73.4% 57.1%
Rocket.Surgery.Extensions.TopographicalSortExtensions 0% 0%
Rocket.Surgery.Extensions.Binding - 77.8%
Name Line Branch
Rocket.Surgery.Extensions.Binding 77.8% 71.1%
Rocket.Surgery.Binding.BackingFieldValueProvider 61.5% 50%
Rocket.Surgery.Binding.JsonBinder 79.1% 76%
Rocket.Surgery.Binding.JsonBinderExtensions 70.7% 57.1%
Rocket.Surgery.Binding.PrivateSetterContractResolver 93.7% 72.7%
Rocket.Surgery.Extensions.Logging - 23%
Name Line Branch
Rocket.Surgery.Extensions.Logging 23% 50%
Rocket.Surgery.Extensions.Logging.LoggingAbstractionsExtensions 23.8% 50%
Rocket.Surgery.Extensions.Logging.LoggingAbstractionsExtensions.Disposable 0%
Rocket.Surgery.Extensions.Logging.LoggingAbstractionsExtensions.NoopDisposa
ble		 100%
Rocket.Surgery.Reflection.Extensions - 46.2%
Name Line Branch
Rocket.Surgery.Reflection.Extensions 46.2% 38.5%
Rocket.Surgery.Reflection.BackingFieldHelper 77.5% 56.6%
Rocket.Surgery.Reflection.InjectableMethodBuilder 70.5% 37.5%
Rocket.Surgery.Reflection.InjectableMethodBuilder<T, T2, T3, T4, T5, T6, T7
, T8, T9, T10, T11, T12>		 24.3% 12.5%
Rocket.Surgery.Reflection.InjectableMethodBuilder<T, T2, T3, T4, T5, T6, T7
, T8, T9, T10, T11>		 25.3% 12.5%
Rocket.Surgery.Reflection.InjectableMethodBuilder<T, T2, T3, T4, T5, T6, T7
, T8, T9, T10>		 25.3% 12.5%
Rocket.Surgery.Reflection.InjectableMethodBuilder<T, T2, T3, T4, T5, T6, T7
, T8, T9>		 25.3% 12.5%
Rocket.Surgery.Reflection.InjectableMethodBuilder<T, T2, T3, T4, T5, T6, T7
, T8>		 25.3% 12.5%
Rocket.Surgery.Reflection.InjectableMethodBuilder<T, T2, T3, T4, T5, T6, T7
>		 25.3% 12.5%
Rocket.Surgery.Reflection.InjectableMethodBuilder<T, T2, T3, T4, T5, T6> 25.4% 12.5%
Rocket.Surgery.Reflection.InjectableMethodBuilder<T, T2, T3, T4, T5> 25.4% 12.5%
Rocket.Surgery.Reflection.InjectableMethodBuilder<T, T2, T3, T4> 25.4% 12.5%
Rocket.Surgery.Reflection.InjectableMethodBuilder<T, T2, T3> 25.5% 12.5%
Rocket.Surgery.Reflection.InjectableMethodBuilder<T, T2> 25.5% 12.5%
Rocket.Surgery.Reflection.InjectableMethodBuilder 46.1% 25%
Rocket.Surgery.Reflection.InjectableMethodBuilderBase 96% 92.8%
Rocket.Surgery.Reflection.MethodNotFoundException 0%
Rocket.Surgery.Reflection.PropertyDelegate 62.9% 50%
Rocket.Surgery.Reflection.PropertyGetter 34.7% 20.2%
Rocket.Surgery.Reflection.TypeDelegate 86.9% 77.5%
Rocket.Surgery.Reflection.TypeDelegate.Info 100% 100%
Rocket.Surgery.Reflection.TypeExtensions 100% 100%
Rocket.Surgery.Reflection.TypeInfoExtensions 0% 0%
Rocket.Surgery.Reflection.ValueExtensions 0%

@david-driscoll david-driscoll enabled auto-merge (squash) December 29, 2024 07:41
@codecov Codecov
Copy link

codecov bot commented Dec 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 94.64286% with 6 lines in your changes missing coverage. Please review.

Project coverage is 72.06%. Comparing base (a9e3122) to head (b113380).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...ers/Configuration/AssemblyProviderConfiguration.cs 82.14% 3 Missing and 2 partials ⚠️
...mpiled/ExcludeFromCompiledTypeProviderAttribute.cs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1432      +/-   ##
==========================================
- Coverage   72.11%   72.06%   -0.06%     
==========================================
  Files         101      102       +1     
  Lines        5196     5208      +12     
  Branches      517      516       -1     
==========================================
+ Hits         3747     3753       +6     
- Misses       1263     1267       +4     
- Partials      186      188       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@david-driscoll david-driscoll force-pushed the simplify-cache-and-reduce-scanned-sassa branch 2 times, most recently from 95cdffb to b22e73f Compare December 29, 2024 07:55
@david-driscoll david-driscoll force-pushed the simplify-cache-and-reduce-scanned-sassa branch from b22e73f to b113380 Compare December 29, 2024 07:58
@david-driscoll david-driscoll merged commit c84c26c into master Dec 29, 2024
8 of 9 checks passed
@david-driscoll david-driscoll deleted the simplify-cache-and-reduce-scanned-sassa branch December 29, 2024 08:05
@github-actions github-actions bot added the ✨ mysterious We forgot to label this label Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
✨ mysterious We forgot to label this
Projects
None yet
Milestone
v13.0.0
Development

Successfully merging this pull request may close these issues.
1 participant
@david-driscoll