Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove iterators #1426

Merged
merged 2 commits into from
Dec 27, 2024
Merged

Remove iterators #1426

merged 2 commits into from
Dec 27, 2024

Conversation

david-driscoll
Copy link
Member

No description provided.

@github-actions github-actions bot added this to the v13.0.0 milestone Dec 27, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 27, 2024 •
edited
Loading

Test Results

    3 files  ±  0      3 suites  ±0   1h 17m 35s ⏱️ + 50m 26s
  670 tests +194    668 ✅ +194  2 💤 ±0  0 ❌ ±0 
1 132 runs  +194  1 128 ✅ +194  4 💤 ±0  0 ❌ ±0 

Results for commit 08e5573. ± Comparison against base commit add7f9e.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 27, 2024 •
edited
Loading

Summary

Summary
Generated on: 12/27/2024 - 05:40:13
Coverage date: 12/27/2024 - 05:40:11
Parser: Cobertura
Assemblies: 6
Classes: 127
Files: 101
Line coverage: 75.6% (3982 of 5265)
Covered lines: 3982
Uncovered lines: 1283
Coverable lines: 5265
Total lines: 10442
Branch coverage: 69% (1361 of 1972)
Covered branches: 1361
Total branches: 1972
Method coverage: Feature is only available for sponsors
Tag: 13.0.0-pr1426.170+Branch.pull-1426-merge.Sha.08c705780e47a4cc5218f89ff17a8c1c576d3bb0

Coverage

Rocket.Surgery.DependencyInjection.Analyzers - 90.4%
Name Line Branch
Rocket.Surgery.DependencyInjection.Analyzers 90.4% 81.1%
Rocket.Surgery.DependencyInjection.Analyzers.AnyTypeData 100%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyCollection 73.7% 86.2%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyCollection.Item 100%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyCollectionData 100%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyFilterData 100%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviderBuilder 100% 95.8%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviderConfiguration 96.7% 89%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviders.AlwaysMatchT
ypeFilter		 0%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviders.CompiledAsse
mblyFilter		 97% 50%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviders.CompiledServ
iceTypeDescriptors		 28.5% 100%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviders.CompiledType
Filter		 100% 91.6%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviders.DataHelpers 95.8% 75.1%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviders.FindTypeInAs
sembly		 100%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviders.FindTypeVisi
tor		 100% 100%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviders.MustBeAnExpr
essionException		 100%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviders.TypeSymbolVi
sitor		 100%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviders.TypeSymbolVi
sitorBase		 100% 80%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviders.TypeSymbolVi
sitorExtensions		 21% 0%
Rocket.Surgery.DependencyInjection.Analyzers.AssignableToAnyTypeData 100%
Rocket.Surgery.DependencyInjection.Analyzers.AssignableToTypeData 100%
Rocket.Surgery.DependencyInjection.Analyzers.CompiledAssemblyProviderData 100% 100%
Rocket.Surgery.DependencyInjection.Analyzers.CompiledServiceScanningGenerat
or		 100% 100%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.AllAssemblyDescrip
tor		 0%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.AssemblyDependenci
esDescriptor		 50%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.AssemblyDescriptor 50%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.AssignableToAnyTyp
eFilterDescriptor		 100%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.AssignableToTypeFi
lterDescriptor		 100%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.CompiledServiceTyp
eDescriptor		 100%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.ImplementedInterfa
cesServiceTypeDescriptor		 100%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.IncludeSystemAssem
bliesDescriptor		 0%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.NameFilterDescript
or		 100%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.NamespaceFilterDes
criptor		 100%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.NotAssemblyDescrip
tor		 50%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.NotAssignableToAny
TypeFilterDescriptor		 0%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.NotAssignableToTyp
eFilterDescriptor		 100%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.TypeInfoFilterDesc
riptor		 100%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.TypeKindFilterDesc
riptor		 100%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.WithAnyAttributeFi
lterDescriptor		 100%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.WithAnyAttributeSt
ringFilterDescriptor		 0%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.WithAttributeFilte
rDescriptor		 100%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.WithAttributeStrin
gFilterDescriptor		 0%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.WithoutAttributeFi
lterDescriptor		 100%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.WithoutAttributeSt
ringFilterDescriptor		 0%
Rocket.Surgery.DependencyInjection.Analyzers.Diagnostics 100%
Rocket.Surgery.DependencyInjection.Analyzers.GetAssemblyConfiguration 100%
Rocket.Surgery.DependencyInjection.Analyzers.GetReflectionCollectionData 100%
Rocket.Surgery.DependencyInjection.Analyzers.GetServiceDescriptorCollection
Data		 100%
Rocket.Surgery.DependencyInjection.Analyzers.Helpers 78.3% 65.2%
Rocket.Surgery.DependencyInjection.Analyzers.NameFilterData 100%
Rocket.Surgery.DependencyInjection.Analyzers.NamespaceFilterData 100%
Rocket.Surgery.DependencyInjection.Analyzers.ReflectionCollection 76.7% 100%
Rocket.Surgery.DependencyInjection.Analyzers.ReflectionCollection.Item 100%
Rocket.Surgery.DependencyInjection.Analyzers.ReflectionCollectionData 100%
Rocket.Surgery.DependencyInjection.Analyzers.ResolvedSourceLocation 100%
Rocket.Surgery.DependencyInjection.Analyzers.SavedSourceLocation 100%
Rocket.Surgery.DependencyInjection.Analyzers.ServiceDescriptorCollection 87.8% 83.1%
Rocket.Surgery.DependencyInjection.Analyzers.ServiceDescriptorCollection.It
em		 100%
Rocket.Surgery.DependencyInjection.Analyzers.ServiceDescriptorCollectionDat
a		 100%
Rocket.Surgery.DependencyInjection.Analyzers.ServiceDescriptorFilterData 100%
Rocket.Surgery.DependencyInjection.Analyzers.ServiceTypeData 100%
Rocket.Surgery.DependencyInjection.Analyzers.SourceLocation 100%
Rocket.Surgery.DependencyInjection.Analyzers.StatementGeneration 89.8% 77.7%
Rocket.Surgery.DependencyInjection.Analyzers.SwitchGenerator 96.5% 88.2%
Rocket.Surgery.DependencyInjection.Analyzers.TypeFilterData 100%
Rocket.Surgery.DependencyInjection.Analyzers.TypeInfoFilterData 100%
Rocket.Surgery.DependencyInjection.Analyzers.TypeKindFilterData 100%
Rocket.Surgery.DependencyInjection.Analyzers.WithAttributeData 100%
Rocket.Surgery.DependencyInjection.Analyzers.WithAttributeStringData 0%
Rocket.Surgery.DependencyInjection.Extensions - 78.9%
Name Line Branch
Rocket.Surgery.DependencyInjection.Extensions 78.9% 48.2%
Rocket.Surgery.DependencyInjection.Compiled.CompiledTypeProviderAttribute 75%
Rocket.Surgery.DependencyInjection.Compiled.CompiledTypeProviderExtensions 100% 50%
Rocket.Surgery.DependencyInjection.Compiled.ICompiledTypeProvider 0% 0%
Rocket.Surgery.DependencyInjection.ExecuteScoped 80.9% 50%
Rocket.Surgery.DependencyInjection.ExecuteScoped<T1, T2, T3, T4, T5, T6> 93.3% 50%
Rocket.Surgery.DependencyInjection.ExecuteScoped<T1, T2, T3, T4, T5> 88.8% 50%
Rocket.Surgery.DependencyInjection.ExecuteScoped<T1, T2, T3, T4> 88.2% 50%
Rocket.Surgery.DependencyInjection.ExecuteScoped<T1, T2, T3> 87.5% 50%
Rocket.Surgery.DependencyInjection.ExecuteScoped<T1, T2> 86.6% 50%
Rocket.Surgery.DependencyInjection.ExecuteScopedOptional 80.9% 50%
Rocket.Surgery.DependencyInjection.ExecuteScopedOptional<T1, T2, T3, T4, T5
, T6>		 93.3% 50%
Rocket.Surgery.DependencyInjection.ExecuteScopedOptional<T1, T2, T3, T4, T5
>		 88.8% 50%
Rocket.Surgery.DependencyInjection.ExecuteScopedOptional<T1, T2, T3, T4> 88.2% 50%
Rocket.Surgery.DependencyInjection.ExecuteScopedOptional<T1, T2, T3> 87.5% 50%
Rocket.Surgery.DependencyInjection.ExecuteScopedOptional<T1, T2> 86.6% 50%
Rocket.Surgery.DependencyInjection.RegistrationLifetimeAttribute 0%
Rocket.Surgery.DependencyInjection.ScopedServiceExtensions 50%
Rocket.Surgery.DependencyInjection.ScopedServiceOptionalExtensions 50%
Rocket.Surgery.DependencyInjection.ServiceRegistrationAttribute 0%
Rocket.Surgery.DependencyInjection.ServiceRegistrationAttribute 0%
Rocket.Surgery.DependencyInjection.ServiceRegistrationAttribute<TService1,
TService2, TService3, TService4>		 0%
Rocket.Surgery.DependencyInjection.ServiceRegistrationAttribute<TService1,
TService2, TService3>		 0%
Rocket.Surgery.DependencyInjection.ServiceRegistrationAttribute<TService1,
TService2>		 0%
Rocket.Surgery.Extensions - 74.7%
Name Line Branch
Rocket.Surgery.Extensions 74.7% 71%
Rocket.Surgery.Extensions.Encoding.Base3264Encoding 93.7% 85.7%
Rocket.Surgery.Extensions.Encoding.Base32Url 79.1% 79.5%
Rocket.Surgery.Extensions.Encoding.Base32Url.CharMap 46.6% 62.5%
Rocket.Surgery.Extensions.Encoding.Base64Url 80% 66.6%
Rocket.Surgery.Extensions.NullableExtensions 73.4% 57.1%
Rocket.Surgery.Extensions.TopographicalSortExtensions 0% 0%
Rocket.Surgery.Extensions.Binding - 77.8%
Name Line Branch
Rocket.Surgery.Extensions.Binding 77.8% 71.1%
Rocket.Surgery.Binding.BackingFieldValueProvider 61.5% 50%
Rocket.Surgery.Binding.JsonBinder 79.1% 76%
Rocket.Surgery.Binding.JsonBinderExtensions 70.7% 57.1%
Rocket.Surgery.Binding.PrivateSetterContractResolver 93.7% 72.7%
Rocket.Surgery.Extensions.Logging - 23%
Name Line Branch
Rocket.Surgery.Extensions.Logging 23% 50%
Rocket.Surgery.Extensions.Logging.LoggingAbstractionsExtensions 23.8% 50%
Rocket.Surgery.Extensions.Logging.LoggingAbstractionsExtensions.Disposable 0%
Rocket.Surgery.Extensions.Logging.LoggingAbstractionsExtensions.NoopDisposa
ble		 100%
Rocket.Surgery.Reflection.Extensions - 46.2%
Name Line Branch
Rocket.Surgery.Reflection.Extensions 46.2% 38.5%
Rocket.Surgery.Reflection.BackingFieldHelper 77.5% 56.6%
Rocket.Surgery.Reflection.InjectableMethodBuilder 70.5% 37.5%
Rocket.Surgery.Reflection.InjectableMethodBuilder<T, T2, T3, T4, T5, T6, T7
, T8, T9, T10, T11, T12>		 24.3% 12.5%
Rocket.Surgery.Reflection.InjectableMethodBuilder<T, T2, T3, T4, T5, T6, T7
, T8, T9, T10, T11>		 25.3% 12.5%
Rocket.Surgery.Reflection.InjectableMethodBuilder<T, T2, T3, T4, T5, T6, T7
, T8, T9, T10>		 25.3% 12.5%
Rocket.Surgery.Reflection.InjectableMethodBuilder<T, T2, T3, T4, T5, T6, T7
, T8, T9>		 25.3% 12.5%
Rocket.Surgery.Reflection.InjectableMethodBuilder<T, T2, T3, T4, T5, T6, T7
, T8>		 25.3% 12.5%
Rocket.Surgery.Reflection.InjectableMethodBuilder<T, T2, T3, T4, T5, T6, T7
>		 25.3% 12.5%
Rocket.Surgery.Reflection.InjectableMethodBuilder<T, T2, T3, T4, T5, T6> 25.4% 12.5%
Rocket.Surgery.Reflection.InjectableMethodBuilder<T, T2, T3, T4, T5> 25.4% 12.5%
Rocket.Surgery.Reflection.InjectableMethodBuilder<T, T2, T3, T4> 25.4% 12.5%
Rocket.Surgery.Reflection.InjectableMethodBuilder<T, T2, T3> 25.5% 12.5%
Rocket.Surgery.Reflection.InjectableMethodBuilder<T, T2> 25.5% 12.5%
Rocket.Surgery.Reflection.InjectableMethodBuilder 46.1% 25%
Rocket.Surgery.Reflection.InjectableMethodBuilderBase 96% 92.8%
Rocket.Surgery.Reflection.MethodNotFoundException 0%
Rocket.Surgery.Reflection.PropertyDelegate 62.9% 50%
Rocket.Surgery.Reflection.PropertyGetter 34.7% 20.2%
Rocket.Surgery.Reflection.TypeDelegate 86.9% 77.5%
Rocket.Surgery.Reflection.TypeDelegate.Info 100% 100%
Rocket.Surgery.Reflection.TypeExtensions 100% 100%
Rocket.Surgery.Reflection.TypeInfoExtensions 0% 0%
Rocket.Surgery.Reflection.ValueExtensions 0%

@codecov Codecov
Copy link

codecov bot commented Dec 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.15%. Comparing base (add7f9e) to head (08e5573).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1426      +/-   ##
==========================================
+ Coverage   71.48%   72.15%   +0.66%     
==========================================
  Files         101      101              
  Lines        5191     5203      +12     
  Branches      519      518       -1     
==========================================
+ Hits         3711     3754      +43     
+ Misses       1293     1263      -30     
+ Partials      187      186       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@david-driscoll david-driscoll enabled auto-merge (squash) December 27, 2024 04:14
@david-driscoll david-driscoll force-pushed the remove-iterators branch 6 times, most recently from 580a4fb to 1c64461 Compare December 27, 2024 05:28
@david-driscoll david-driscoll merged commit fa310ca into master Dec 27, 2024
6 of 7 checks passed
@david-driscoll david-driscoll deleted the remove-iterators branch December 27, 2024 05:40
@github-actions github-actions bot added the ✨ mysterious We forgot to label this label Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
✨ mysterious We forgot to label this
Projects
None yet
Milestone
v13.0.0
Development

Successfully merging this pull request may close these issues.
1 participant
@david-driscoll