Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nested types can be annoying, so lets fix that #1343

Merged
merged 2 commits into from
Nov 28, 2024
Merged

nested types can be annoying, so lets fix that #1343

merged 2 commits into from
Nov 28, 2024

Conversation

david-driscoll
Copy link
Member

No description provided.

@github-actions github-actions bot added this to the v13.0.0 milestone Nov 28, 2024
@david-driscoll david-driscoll enabled auto-merge (squash) November 28, 2024 01:36
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 28, 2024 •
edited
Loading

Summary

Summary
Generated on: 11/28/2024 - 01:41:12
Coverage date: 11/28/2024 - 01:41:11
Parser: Cobertura
Assemblies: 6
Classes: 124
Files: 81
Line coverage: 71% (3580 of 5039)
Covered lines: 3580
Uncovered lines: 1459
Coverable lines: 5039
Total lines: 9904
Branch coverage: 64.6% (1238 of 1916)
Covered branches: 1238
Total branches: 1916
Method coverage: Feature is only available for sponsors
Tag: 13.0.0-pr1343.87+Branch.pull-1343-merge.Sha.ac06c29c9dc9dc3933d5192e3016392a6034b52b

Coverage

Rocket.Surgery.DependencyInjection.Analyzers - 82.6%
Name Line Branch
Rocket.Surgery.DependencyInjection.Analyzers 82.6% 74.2%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyCollection 60.6% 38.2%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyCollection.CollectRequ
est		 100%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyCollection.Item 0%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyCollection.Request 100%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviderConfiguration 87.8% 79.8%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviderConfiguration.
AnyTypeData		 100%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviderConfiguration.
AssemblyCollectionData		 0%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviderConfiguration.
AssemblyFilterData		 100%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviderConfiguration.
AssignableToAnyTypeData		 100%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviderConfiguration.
AssignableToTypeData		 100%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviderConfiguration.
NameFilterData		 100%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviderConfiguration.
NamespaceFilterData		 100%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviderConfiguration.
ReflectionCollectionData		 100%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviderConfiguration.
ServiceDescriptorCollectionData		 100%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviderConfiguration.
ServiceDescriptorFilterData		 100%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviderConfiguration.
ServiceTypeData		 100%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviderConfiguration.
TypeFilterData		 100%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviderConfiguration.
TypeInfoFilterData		 100%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviderConfiguration.
TypeKindFilterData		 100%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviderConfiguration.
WithAttributeData		 100%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviderConfiguration.
WithAttributeStringData		 0%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviders.AlwaysMatchT
ypeFilter		 0%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviders.CompiledAsse
mblyFilter		 100% 83.3%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviders.CompiledServ
iceTypeDescriptors		 28.5% 100%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviders.CompiledType
Filter		 100% 87.5%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviders.DataHelpers 95.2% 74.8%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviders.FindTypeInAs
sembly		 0%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviders.FindTypeVisi
tor		 100% 100%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviders.MustBeAnExpr
essionException		 100%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviders.TypeSymbolVi
sitor		 89.4% 83.3%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviders.TypeSymbolVi
sitorBase		 100% 80%
Rocket.Surgery.DependencyInjection.Analyzers.CompiledServiceScanningGenerat
or		 100% 100%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.AllAssemblyDescrip
tor		 0%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.AssemblyDependenci
esDescriptor		 50%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.AssemblyDescriptor 50%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.AssignableToAnyTyp
eFilterDescriptor		 100%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.AssignableToTypeFi
lterDescriptor		 100%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.CompiledServiceTyp
eDescriptor		 100%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.ImplementedInterfa
cesServiceTypeDescriptor		 100%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.IncludeSystemAssem
bliesDescriptor		 0%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.NameFilterDescript
or		 100%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.NamespaceFilterDes
criptor		 100%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.NotAssemblyDescrip
tor		 50%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.NotAssignableToAny
TypeFilterDescriptor		 0%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.NotAssignableToTyp
eFilterDescriptor		 100%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.TypeInfoFilterDesc
riptor		 100%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.TypeKindFilterDesc
riptor		 100%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.WithAnyAttributeFi
lterDescriptor		 100%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.WithAnyAttributeSt
ringFilterDescriptor		 0%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.WithAttributeFilte
rDescriptor		 100%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.WithAttributeStrin
gFilterDescriptor		 0%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.WithoutAttributeFi
lterDescriptor		 100%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.WithoutAttributeSt
ringFilterDescriptor		 0%
Rocket.Surgery.DependencyInjection.Analyzers.Diagnostics 100%
Rocket.Surgery.DependencyInjection.Analyzers.Helpers 87.4% 72.5%
Rocket.Surgery.DependencyInjection.Analyzers.ReflectionCollection 80.3% 90.7%
Rocket.Surgery.DependencyInjection.Analyzers.ReflectionCollection.Item 100%
Rocket.Surgery.DependencyInjection.Analyzers.ReflectionCollection.Request 100%
Rocket.Surgery.DependencyInjection.Analyzers.ServiceDescriptorCollection 88.1% 82.9%
Rocket.Surgery.DependencyInjection.Analyzers.ServiceDescriptorCollection.It
em		 100%
Rocket.Surgery.DependencyInjection.Analyzers.ServiceDescriptorCollection.Re
quest		 100%
Rocket.Surgery.DependencyInjection.Analyzers.SourceLocation 100%
Rocket.Surgery.DependencyInjection.Analyzers.StatementGeneration 73% 65.5%
Rocket.Surgery.DependencyInjection.Analyzers.SwitchGenerator 96.2% 87.5%
Rocket.Surgery.DependencyInjection.Analyzers.TypeSymbolVisitor 0% 0%
Rocket.Surgery.DependencyInjection.Extensions - 78.9%
Name Line Branch
Rocket.Surgery.DependencyInjection.Extensions 78.9% 48.2%
Rocket.Surgery.DependencyInjection.Compiled.CompiledTypeProviderAttribute 75%
Rocket.Surgery.DependencyInjection.Compiled.CompiledTypeProviderExtensions 100% 50%
Rocket.Surgery.DependencyInjection.Compiled.ICompiledTypeProvider 0% 0%
Rocket.Surgery.DependencyInjection.ExecuteScoped 80.9% 50%
Rocket.Surgery.DependencyInjection.ExecuteScoped<T1, T2, T3, T4, T5, T6> 93.3% 50%
Rocket.Surgery.DependencyInjection.ExecuteScoped<T1, T2, T3, T4, T5> 88.8% 50%
Rocket.Surgery.DependencyInjection.ExecuteScoped<T1, T2, T3, T4> 88.2% 50%
Rocket.Surgery.DependencyInjection.ExecuteScoped<T1, T2, T3> 87.5% 50%
Rocket.Surgery.DependencyInjection.ExecuteScoped<T1, T2> 86.6% 50%
Rocket.Surgery.DependencyInjection.ExecuteScopedOptional 80.9% 50%
Rocket.Surgery.DependencyInjection.ExecuteScopedOptional<T1, T2, T3, T4, T5
, T6>		 93.3% 50%
Rocket.Surgery.DependencyInjection.ExecuteScopedOptional<T1, T2, T3, T4, T5
>		 88.8% 50%
Rocket.Surgery.DependencyInjection.ExecuteScopedOptional<T1, T2, T3, T4> 88.2% 50%
Rocket.Surgery.DependencyInjection.ExecuteScopedOptional<T1, T2, T3> 87.5% 50%
Rocket.Surgery.DependencyInjection.ExecuteScopedOptional<T1, T2> 86.6% 50%
Rocket.Surgery.DependencyInjection.RegistrationLifetimeAttribute 0%
Rocket.Surgery.DependencyInjection.ScopedServiceExtensions 50%
Rocket.Surgery.DependencyInjection.ScopedServiceOptionalExtensions 50%
Rocket.Surgery.DependencyInjection.ServiceRegistrationAttribute 0%
Rocket.Surgery.DependencyInjection.ServiceRegistrationAttribute 0%
Rocket.Surgery.DependencyInjection.ServiceRegistrationAttribute<TService1,
TService2, TService3, TService4>		 0%
Rocket.Surgery.DependencyInjection.ServiceRegistrationAttribute<TService1,
TService2, TService3>		 0%
Rocket.Surgery.DependencyInjection.ServiceRegistrationAttribute<TService1,
TService2>		 0%
Rocket.Surgery.Extensions - 74.7%
Name Line Branch
Rocket.Surgery.Extensions 74.7% 71%
Rocket.Surgery.Extensions.Encoding.Base3264Encoding 93.7% 85.7%
Rocket.Surgery.Extensions.Encoding.Base32Url 79.1% 79.5%
Rocket.Surgery.Extensions.Encoding.Base32Url.CharMap 46.6% 62.5%
Rocket.Surgery.Extensions.Encoding.Base64Url 80% 66.6%
Rocket.Surgery.Extensions.NullableExtensions 73.4% 57.1%
Rocket.Surgery.Extensions.TopographicalSortExtensions 0% 0%
Rocket.Surgery.Extensions.Binding - 77.8%
Name Line Branch
Rocket.Surgery.Extensions.Binding 77.8% 71.1%
Rocket.Surgery.Binding.BackingFieldValueProvider 61.5% 50%
Rocket.Surgery.Binding.JsonBinder 79.1% 76%
Rocket.Surgery.Binding.JsonBinderExtensions 70.7% 57.1%
Rocket.Surgery.Binding.PrivateSetterContractResolver 93.7% 72.7%
Rocket.Surgery.Extensions.Logging - 23%
Name Line Branch
Rocket.Surgery.Extensions.Logging 23% 50%
Rocket.Surgery.Extensions.Logging.LoggingAbstractionsExtensions 23.8% 50%
Rocket.Surgery.Extensions.Logging.LoggingAbstractionsExtensions.Disposable 0%
Rocket.Surgery.Extensions.Logging.LoggingAbstractionsExtensions.NoopDisposa
ble		 100%
Rocket.Surgery.Reflection.Extensions - 46.2%
Name Line Branch
Rocket.Surgery.Reflection.Extensions 46.2% 38.5%
Rocket.Surgery.Reflection.BackingFieldHelper 77.5% 56.6%
Rocket.Surgery.Reflection.InjectableMethodBuilder 70.5% 37.5%
Rocket.Surgery.Reflection.InjectableMethodBuilder<T, T2, T3, T4, T5, T6, T7
, T8, T9, T10, T11, T12>		 24.3% 12.5%
Rocket.Surgery.Reflection.InjectableMethodBuilder<T, T2, T3, T4, T5, T6, T7
, T8, T9, T10, T11>		 25.3% 12.5%
Rocket.Surgery.Reflection.InjectableMethodBuilder<T, T2, T3, T4, T5, T6, T7
, T8, T9, T10>		 25.3% 12.5%
Rocket.Surgery.Reflection.InjectableMethodBuilder<T, T2, T3, T4, T5, T6, T7
, T8, T9>		 25.3% 12.5%
Rocket.Surgery.Reflection.InjectableMethodBuilder<T, T2, T3, T4, T5, T6, T7
, T8>		 25.3% 12.5%
Rocket.Surgery.Reflection.InjectableMethodBuilder<T, T2, T3, T4, T5, T6, T7
>		 25.3% 12.5%
Rocket.Surgery.Reflection.InjectableMethodBuilder<T, T2, T3, T4, T5, T6> 25.4% 12.5%
Rocket.Surgery.Reflection.InjectableMethodBuilder<T, T2, T3, T4, T5> 25.4% 12.5%
Rocket.Surgery.Reflection.InjectableMethodBuilder<T, T2, T3, T4> 25.4% 12.5%
Rocket.Surgery.Reflection.InjectableMethodBuilder<T, T2, T3> 25.5% 12.5%
Rocket.Surgery.Reflection.InjectableMethodBuilder<T, T2> 25.5% 12.5%
Rocket.Surgery.Reflection.InjectableMethodBuilder 46.1% 25%
Rocket.Surgery.Reflection.InjectableMethodBuilderBase 96% 92.8%
Rocket.Surgery.Reflection.MethodNotFoundException 0%
Rocket.Surgery.Reflection.PropertyDelegate 62.9% 50%
Rocket.Surgery.Reflection.PropertyGetter 34.7% 20.2%
Rocket.Surgery.Reflection.TypeDelegate 86.9% 77.5%
Rocket.Surgery.Reflection.TypeDelegate.Info 100% 100%
Rocket.Surgery.Reflection.TypeExtensions 100% 100%
Rocket.Surgery.Reflection.TypeInfoExtensions 0% 0%
Rocket.Surgery.Reflection.ValueExtensions 0%

@github-actions GitHub Actions
Copy link

Test Results

  3 files  ±0    3 suites  ±0   9m 13s ⏱️ - 4m 5s
356 tests ±0  355 ✅ ±0  1 💤 ±0  0 ❌ ±0 
870 runs  +4  866 ✅ +4  4 💤 ±0  0 ❌ ±0 

Results for commit 14ddcc7. ± Comparison against base commit 1b44247.

@david-driscoll david-driscoll merged commit 204d4e9 into master Nov 28, 2024
7 checks passed
@david-driscoll david-driscoll deleted the fix/for-real branch November 28, 2024 01:42
@github-actions github-actions bot added the ✨ mysterious We forgot to label this label Nov 28, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.52%. Comparing base (1b44247) to head (14ddcc7).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1343      +/-   ##
==========================================
- Coverage   66.62%   66.52%   -0.10%     
==========================================
  Files          81       81              
  Lines        4854     4828      -26     
  Branches      512      512              
==========================================
- Hits         3234     3212      -22     
+ Misses       1427     1425       -2     
+ Partials      193      191       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
✨ mysterious We forgot to label this
Projects
None yet
Milestone
v13.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@david-driscoll @rsg-bot