Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compiled type provider was getting types properly #1326

Merged
merged 3 commits into from
Nov 22, 2024
Merged

Conversation

david-driscoll
Copy link
Member

No description provided.

@github-actions github-actions bot added this to the v13.0.0 milestone Nov 22, 2024
Copy link

github-actions bot commented Nov 22, 2024

Test Results

  3 files   -   1    3 suites   - 1   1m 51s ⏱️ - 3m 22s
588 tests +  8  588 ✅ +  8  0 💤 ±0  0 ❌ ±0 
990 runs   - 170  990 ✅  - 170  0 💤 ±0  0 ❌ ±0 

Results for commit 05e43ce. ± Comparison against base commit a61d063.

♻️ This comment has been updated with latest results.

@david-driscoll david-driscoll force-pushed the fix/gettypes branch 3 times, most recently from 869605f to 191cf7d Compare November 22, 2024 03:28
@david-driscoll david-driscoll force-pushed the fix/gettypes branch 3 times, most recently from 8c8adef to d0abcea Compare November 22, 2024 03:50
Copy link

Summary

Summary
Generated on: 11/22/2024 - 03:53:50
Coverage date: 11/22/2024 - 03:53:48
Parser: Cobertura
Assemblies: 9
Classes: 171
Files: 94
Line coverage: 78.7% (6083 of 7724)
Covered lines: 6083
Uncovered lines: 1641
Coverable lines: 7724
Total lines: 19642
Branch coverage: 66.1% (1391 of 2102)
Covered branches: 1391
Total branches: 2102
Method coverage: Feature is only available for sponsors
Tag: 13.0.0-pr1326.70+Branch.pull-1326-merge.Sha.e532cc4e0a37bbe85a3e5106cad2f6832697f667

Coverage

Rocket.Surgery.DependencyInjection.Analyzers - 85.1%
Name Line Branch
Rocket.Surgery.DependencyInjection.Analyzers 85.1% 73.5%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyCollection 67.2% 38.2%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyCollection.CollectRequ
est
100%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyCollection.Item 0%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyCollection.Request 100%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviderConfiguration 90% 83.6%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviderConfiguration.
AnyTypeData
100%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviderConfiguration.
AssemblyCollectionData
0%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviderConfiguration.
AssemblyFilterData
100%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviderConfiguration.
AssignableToAnyTypeData
100%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviderConfiguration.
AssignableToTypeData
100%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviderConfiguration.
NameFilterData
100%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviderConfiguration.
NamespaceFilterData
100%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviderConfiguration.
ReflectionCollectionData
100%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviderConfiguration.
ServiceDescriptorCollectionData
100%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviderConfiguration.
ServiceDescriptorFilterData
100%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviderConfiguration.
TypeFilterData
100%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviderConfiguration.
TypeInfoFilterData
100%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviderConfiguration.
TypeKindFilterData
100%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviderConfiguration.
WithAttributeData
100%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviderConfiguration.
WithAttributeStringData
100%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviders.AlwaysMatchT
ypeFilter
0%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviders.CompiledAsse
mblyFilter
100% 83.3%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviders.CompiledServ
iceTypeDescriptors
28.5% 100%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviders.CompiledType
Filter
100% 87.5%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviders.DataHelpers 95.8% 75.5%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviders.FindTypeInAs
sembly
0%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviders.FindTypeVisi
tor
100% 100%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviders.MustBeAnExpr
essionException
100%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviders.StatementGen
eration
54.5% 44.1%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviders.TypeSymbolVi
sitor
90.4% 83.3%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviders.TypeSymbolVi
sitorBase
100% 80%
Rocket.Surgery.DependencyInjection.Analyzers.CompiledServiceScanningGenerat
or
100% 100%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.AllAssemblyDescrip
tor
0%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.AssemblyDependenci
esDescriptor
0%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.AssemblyDescriptor 0%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.IncludeSystemAssem
bliesDescriptor
0%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.NotAssemblyDescrip
tor
0%
Rocket.Surgery.DependencyInjection.Analyzers.Diagnostics 100%
Rocket.Surgery.DependencyInjection.Analyzers.Helpers 79.7% 61.1%
Rocket.Surgery.DependencyInjection.Analyzers.ReflectionCollection 96.8% 90.7%
Rocket.Surgery.DependencyInjection.Analyzers.ReflectionCollection.Item 100%
Rocket.Surgery.DependencyInjection.Analyzers.ReflectionCollection.Request 100%
Rocket.Surgery.DependencyInjection.Analyzers.ServiceDescriptorCollection 94.5% 84.4%
Rocket.Surgery.DependencyInjection.Analyzers.ServiceDescriptorCollection.It
em
100%
Rocket.Surgery.DependencyInjection.Analyzers.ServiceDescriptorCollection.Re
quest
100%
Rocket.Surgery.DependencyInjection.Analyzers.SourceLocation 100%
Rocket.Surgery.DependencyInjection.Analyzers.StatementGeneration 100% 87.5%
Rocket.Surgery.DependencyInjection.Analyzers.SwitchGenerator 96.2% 87.5%
Rocket.Surgery.DependencyInjection.Analyzers.TypeSymbolVisitor 0% 0%
Rocket.Surgery.DependencyInjection.Analyzers.Tests - 81.4%
Name Line Branch
Rocket.Surgery.DependencyInjection.Analyzers.Tests 81.4% 72.5%
Rocket.Surgery.DependencyInjection.Analyzers.Tests.AssemblyScanningTests 100%
Rocket.Surgery.DependencyInjection.Analyzers.Tests.CollectibleTestAssemblyL
oadContext
100%
Rocket.Surgery.DependencyInjection.Analyzers.Tests.GeneratorTest 100% 100%
Rocket.Surgery.DependencyInjection.Analyzers.Tests.GeneratorTestResultsWith
Services
100%
Rocket.Surgery.DependencyInjection.Analyzers.Tests.GetTypesTestsData.GetTyp
esItem
100%
Rocket.Surgery.DependencyInjection.Analyzers.Tests.ModuleInitializer 82.4% 80%
Rocket.Surgery.DependencyInjection.Analyzers.Tests.ModuleInitializer.Servic
eDescriptorConverter
48.8% 44.4%
Rocket.Surgery.DependencyInjection.Analyzers.Tests.StaticScanning_WithAssem
blyLoadTests
100% 100%
Rocket.Surgery.DependencyInjection.Analyzers.Tests.StaticScanning_WithAssem
blyLoadTests.StaticHelper
100% 100%
Rocket.Surgery.DependencyInjection.Analyzers.Tests.StaticScanningTests 100% 50%
Rocket.Surgery.DependencyInjection.Analyzers.Tests.StaticScanningTests.Stat
icHelper
100% 50%
Rocket.Surgery.DependencyInjection.Extensions - 78.9%
Name Line Branch
Rocket.Surgery.DependencyInjection.Extensions 78.9% 48.2%
Rocket.Surgery.DependencyInjection.Compiled.CompiledTypeProviderAttribute 75%
Rocket.Surgery.DependencyInjection.Compiled.CompiledTypeProviderExtensions 100% 50%
Rocket.Surgery.DependencyInjection.Compiled.ICompiledTypeProvider 0% 0%
Rocket.Surgery.DependencyInjection.ExecuteScoped 80.9% 50%
Rocket.Surgery.DependencyInjection.ExecuteScoped<T1, T2, T3, T4, T5, T6> 93.3% 50%
Rocket.Surgery.DependencyInjection.ExecuteScoped<T1, T2, T3, T4, T5> 88.8% 50%
Rocket.Surgery.DependencyInjection.ExecuteScoped<T1, T2, T3, T4> 88.2% 50%
Rocket.Surgery.DependencyInjection.ExecuteScoped<T1, T2, T3> 87.5% 50%
Rocket.Surgery.DependencyInjection.ExecuteScoped<T1, T2> 86.6% 50%
Rocket.Surgery.DependencyInjection.ExecuteScopedOptional 80.9% 50%
Rocket.Surgery.DependencyInjection.ExecuteScopedOptional<T1, T2, T3, T4, T5
, T6>
93.3% 50%
Rocket.Surgery.DependencyInjection.ExecuteScopedOptional<T1, T2, T3, T4, T5
>
88.8% 50%
Rocket.Surgery.DependencyInjection.ExecuteScopedOptional<T1, T2, T3, T4> 88.2% 50%
Rocket.Surgery.DependencyInjection.ExecuteScopedOptional<T1, T2, T3> 87.5% 50%
Rocket.Surgery.DependencyInjection.ExecuteScopedOptional<T1, T2> 86.6% 50%
Rocket.Surgery.DependencyInjection.RegistrationLifetimeAttribute 0%
Rocket.Surgery.DependencyInjection.ScopedServiceExtensions 50%
Rocket.Surgery.DependencyInjection.ScopedServiceOptionalExtensions 50%
Rocket.Surgery.DependencyInjection.ServiceRegistrationAttribute 0%
Rocket.Surgery.DependencyInjection.ServiceRegistrationAttribute 0%
Rocket.Surgery.DependencyInjection.ServiceRegistrationAttribute<TService1,
TService2, TService3, TService4>
0%
Rocket.Surgery.DependencyInjection.ServiceRegistrationAttribute<TService1,
TService2, TService3>
0%
Rocket.Surgery.DependencyInjection.ServiceRegistrationAttribute<TService1,
TService2>
0%
Rocket.Surgery.Extensions - 78%
Name Line Branch
Rocket.Surgery.Extensions 78% 71.3%
Rocket.Surgery.Encoding.Base3264Encoding 94.5% 85.7%
Rocket.Surgery.Encoding.Base32Url 80.1% 81.6%
Rocket.Surgery.Encoding.Base32Url.CharMap 46.6% 62.5%
Rocket.Surgery.Encoding.Base64Url 80% 66.6%
Rocket.Surgery.Extensions.NullableExtensions 72.9% 57.1%
Rocket.Surgery.Extensions.TopographicalSortExtensions 0% 0%
Rocket.Surgery.Extensions.Binding - 77%
Name Line Branch
Rocket.Surgery.Extensions.Binding 77% 71.1%
Rocket.Surgery.Binding.BackingFieldValueProvider 61.5% 50%
Rocket.Surgery.Binding.JsonBinder 77.9% 76%
Rocket.Surgery.Binding.JsonBinderExtensions 70.7% 57.1%
Rocket.Surgery.Binding.PrivateSetterContractResolver 93.7% 72.7%
Rocket.Surgery.Extensions.Logging - 28.5%
Name Line Branch
Rocket.Surgery.Extensions.Logging 28.5% 50%
Rocket.Surgery.Extensions.Logging.LoggingAbstractionsExtensions 27.2% 50%
Rocket.Surgery.Extensions.Logging.LoggingAbstractionsExtensions.Disposable 0%
Rocket.Surgery.Extensions.Logging.LoggingAbstractionsExtensions.NoopDisposa
ble
100%
Rocket.Surgery.Extensions.Tests - 92.6%
Name Line Branch
Rocket.Surgery.Extensions.Tests 92.6% 96%
Rocket.Surgery.Extensions.Tests.BackingFieldTests 92.8%
Rocket.Surgery.Extensions.Tests.BackingFieldTests.BackingField4 50%
Rocket.Surgery.Extensions.Tests.BackingFieldTests.ExplictField2 100%
Rocket.Surgery.Extensions.Tests.DeconstructorExtensionsTests 100%
Rocket.Surgery.Extensions.Tests.DependencyInjection.ExecuteScopedOptionalTe
sts
100%
Rocket.Surgery.Extensions.Tests.DependencyInjection.ExecuteScopedOptionalTe
sts.ScopedValue
100%
Rocket.Surgery.Extensions.Tests.DependencyInjection.ExecuteScopedOptionalTe
sts.Service1
100%
Rocket.Surgery.Extensions.Tests.DependencyInjection.ExecuteScopedOptionalTe
sts.Service2
100%
Rocket.Surgery.Extensions.Tests.DependencyInjection.ExecuteScopedOptionalTe
sts.Service3
100%
Rocket.Surgery.Extensions.Tests.DependencyInjection.ExecuteScopedOptionalTe
sts.Service4
100%
Rocket.Surgery.Extensions.Tests.DependencyInjection.ExecuteScopedOptionalTe
sts.Service5
100%
Rocket.Surgery.Extensions.Tests.DependencyInjection.ExecuteScopedOptionalTe
sts.Service6
100%
Rocket.Surgery.Extensions.Tests.DependencyInjection.ExecuteScopedTests 100%
Rocket.Surgery.Extensions.Tests.DependencyInjection.ExecuteScopedTests.Scop
edValue
100%
Rocket.Surgery.Extensions.Tests.DependencyInjection.ExecuteScopedTests.Serv
ice1
100%
Rocket.Surgery.Extensions.Tests.DependencyInjection.ExecuteScopedTests.Serv
ice2
100%
Rocket.Surgery.Extensions.Tests.DependencyInjection.ExecuteScopedTests.Serv
ice3
100%
Rocket.Surgery.Extensions.Tests.DependencyInjection.ExecuteScopedTests.Serv
ice4
100%
Rocket.Surgery.Extensions.Tests.DependencyInjection.ExecuteScopedTests.Serv
ice5
100%
Rocket.Surgery.Extensions.Tests.DependencyInjection.ExecuteScopedTests.Serv
ice6
100%
Rocket.Surgery.Extensions.Tests.Encoding.Base3264EncodingTests 100% 100%
Rocket.Surgery.Extensions.Tests.Encoding.Base32UrlTests 100% 100%
Rocket.Surgery.Extensions.Tests.InjectableMethodBuilderTests 100%
Rocket.Surgery.Extensions.Tests.InjectableMethodTests 86.3% 75%
Rocket.Surgery.Extensions.Tests.InjectableMethodTests.MethodFuncTest 0%
Rocket.Surgery.Extensions.Tests.InjectableMethodTests.MethodFuncTest2 0%
Rocket.Surgery.Extensions.Tests.InjectableMethodTests.MethodFuncTest3 0%
Rocket.Surgery.Extensions.Tests.InjectableMethodTests.MethodFuncTestStatic 60% 50%
Rocket.Surgery.Extensions.Tests.JsonBinderTests 100% 100%
Rocket.Surgery.Extensions.Tests.Logging.LoggingExtensionTests 100% 100%
Rocket.Surgery.Extensions.Tests.MethodFuncTest 22.3%
Rocket.Surgery.Extensions.Tests.NullableTests 84.6%
Rocket.Surgery.Extensions.Tests.NullableTests.DisabledNullableTest 0%
Rocket.Surgery.Extensions.Tests.NullableTests.NonNullableTest 0%
Rocket.Surgery.Extensions.Tests.NullableTests.NullableTest 0%
Rocket.Surgery.Extensions.Tests.NullableTests.ValueNonNullableTest 0%
Rocket.Surgery.Extensions.Tests.NullableTests.ValueNullableTest 0%
Rocket.Surgery.Extensions.Tests.Observables.DebounceTests 100%
Rocket.Surgery.Extensions.Tests.Observables.Helpers 81.6% 80%
Rocket.Surgery.Extensions.Tests.Observables.Helpers.UnitObserver 78.5%
Rocket.Surgery.Extensions.Tests.Observables.RealThrottleTests 100%
Rocket.Surgery.Extensions.Tests.PropertyGetterTests 100%
Rocket.Surgery.Extensions.Tests.Unions.Base 100%
Rocket.Surgery.Extensions.Tests.Unions.Thing1 100%
Rocket.Surgery.Extensions.Tests.Unions.Thing2 100%
Rocket.Surgery.Extensions.Tests.Unions.UnionTests 100%
Rocket.Surgery.Extensions.Unions - 86.3%
Name Line Branch
Rocket.Surgery.Extensions.Unions 86.3% 64%
Rocket.Surgery.Unions.Inflector 100% 75%
Rocket.Surgery.Unions.UnionAttribute 83.3% 50%
Rocket.Surgery.Unions.UnionContext 100% 50%
Rocket.Surgery.Unions.UnionConverter 80% 90%
Rocket.Surgery.Unions.UnionHelper 81.3% 60.5%
Rocket.Surgery.Unions.UnionKeyAttribute 83.3% 50%
Rocket.Surgery.Reflection.Extensions - 47.4%
Name Line Branch
Rocket.Surgery.Reflection.Extensions 47.4% 40.3%
Rocket.Surgery.Reflection.BackingFieldHelper 80% 63.3%
Rocket.Surgery.Reflection.InjectableMethodBuilder 78.2% 37.5%
Rocket.Surgery.Reflection.InjectableMethodBuilder<T, T2, T3, T4, T5, T6, T7
, T8, T9, T10, T11, T12>
25.5% 12.5%
Rocket.Surgery.Reflection.InjectableMethodBuilder<T, T2, T3, T4, T5, T6, T7
, T8, T9, T10, T11>
28.2% 12.5%
Rocket.Surgery.Reflection.InjectableMethodBuilder<T, T2, T3, T4, T5, T6, T7
, T8, T9, T10>
28.3% 12.5%
Rocket.Surgery.Reflection.InjectableMethodBuilder<T, T2, T3, T4, T5, T6, T7
, T8, T9>
28.5% 12.5%
Rocket.Surgery.Reflection.InjectableMethodBuilder<T, T2, T3, T4, T5, T6, T7
, T8>
28.7% 12.5%
Rocket.Surgery.Reflection.InjectableMethodBuilder<T, T2, T3, T4, T5, T6, T7
>
28.9% 12.5%
Rocket.Surgery.Reflection.InjectableMethodBuilder<T, T2, T3, T4, T5, T6> 29.2% 12.5%
Rocket.Surgery.Reflection.InjectableMethodBuilder<T, T2, T3, T4, T5> 29.5% 12.5%
Rocket.Surgery.Reflection.InjectableMethodBuilder<T, T2, T3, T4> 29.8% 12.5%
Rocket.Surgery.Reflection.InjectableMethodBuilder<T, T2, T3> 30.1% 12.5%
Rocket.Surgery.Reflection.InjectableMethodBuilder<T, T2> 30.6% 12.5%
Rocket.Surgery.Reflection.InjectableMethodBuilder 48.8% 25%
Rocket.Surgery.Reflection.InjectableMethodBuilderBase 96% 92.8%
Rocket.Surgery.Reflection.MethodNotFoundException 0%
Rocket.Surgery.Reflection.PropertyDelegate 48.7% 50%
Rocket.Surgery.Reflection.PropertyGetter 34.7% 20.2%
Rocket.Surgery.Reflection.TypeDelegate 87.6% 87.9%
Rocket.Surgery.Reflection.TypeDelegate.Info 100% 100%
Rocket.Surgery.Reflection.TypeExtensions 100% 100%
Rocket.Surgery.Reflection.TypeInfoExtensions 0% 0%
Rocket.Surgery.Reflection.ValueExtensions 0%

@david-driscoll david-driscoll merged commit cfbda21 into master Nov 22, 2024
7 checks passed
@david-driscoll david-driscoll deleted the fix/gettypes branch November 22, 2024 03:54
@github-actions github-actions bot added the ✨ mysterious We forgot to label this label Nov 22, 2024
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 73.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 76.06%. Comparing base (a61d063) to head (05e43ce).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...ependencyInjection.Analyzers/AssemblyCollection.cs 33.33% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1326      +/-   ##
==========================================
+ Coverage   74.25%   76.06%   +1.81%     
==========================================
  Files          94       94              
  Lines        7364     7362       -2     
  Branches      595      593       -2     
==========================================
+ Hits         5468     5600     +132     
+ Misses       1684     1558     -126     
+ Partials      212      204       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ mysterious We forgot to label this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants