-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NEW] Message read receipts #9717
Conversation
95bf5ae
to
f5d9132
Compare
the PR is ready for merge, I would like to have @RocketChat/core eyes on it pls 😃 |
My only dislike is visual. It seems like putting this there would lead to it being very noisy. Could it maybe be next to time stamp? Maybe on grouped messages could actually show up on hover like the timestamp does? That or right justify it to be in a more consistent place? Imagine every message length is different, the check marks will be all over the page. Also perhaps a bit smaller? The other thing is next to join messages those don't seem to be getting updated. So maybe need a way to not apply read receipts to messages based on something in message type definition? |
this is how @arthurgiustina designed. I kind of agree with you, but not sure where it should be.
I'll have to give this a look, thx |
what do you guys think on having a permission to enable seeing read receipts from other persons? the default might be only for admins, owners and moderators but this would allow people to have more control on this. so the default would be you can see read receipts for your own messages only, but admins/owners/moderators can see every ones. |
@geekgonecrazy I've changed a few things, please let me know what you think =)
|
I'm not sure why that blue is so satisfying. But I like it. Not sure about placement. 🤔 For some reason it not long shows up on my own messages. I wonder if it should only even actually show on own messages? Or maybe configurable. |
@sampaiodiego glad to see I'm not the only one who has started to use the new es6 features for packages 😉 #nomoreglobals |
@sampaiodiego Since we're going to implement this feature on the mobile apps, is this new property Also, could you please work on a new REST API that returns the return of the new Meteor method |
For sure! @rafaelks |
@sampaiodiego @MarcosSpessatto Is there any way to know whether the message is delivered or not? |
@mrqbmrqb no there is not. |
I know this thread is older but I was curious if this feature of knowing when people read the message was ever implemented? If so is it available in the free version or just the paid version? thank you. |
@dcook1313 yes it was. you have to enabled it from Admin panel, |
Thank you very much Diego. :) |
Closes #3411
With this PR I'm proposing a new folder structure for features/packages, using new Meteor proposal as well ES2015 imports.
Please let me know what y'll think on this.
About the feature, it starts disabled by default, if enabled it will add a gray
check
on every message. If it was read by everyone on the room it will turn blue.There is another setting (also disabled by default) that will start storing the read time of everyone. So you'll be able to see the message's read receipts by looking at the
Message info
message action.Please advice on settings label and description, I'm not sure they are clear enough.
Settings
Check marks detail
The blue one means read by everyone.
New message action to see message info
Message info modal