[FIX] Always set LDAP properties on login #7472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sampaiodiego
changed the title
rodrigok
approved these changes
Jul 14, 2017
This was referenced Jul 14, 2017
rodrigok
added a commit
that referenced
this pull request
Jul 14, 2017
[FIX] Always set LDAP properties on login
|
Using .62.2 I was forced to enable the "merge" option for some users to be able to login. This was a fresh install of RocketChat server, and the users had never logged in before today, but until I chose the "merge" option, they could only login using their email address. Since there should have been nothing new to "merge," it sure seems like this is still some sort of LDAP bug. Also, disabling/reenabling Avatar sync had no effect either way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
This PR will prevent new LDAP logins from being stuck even if
Merge existing usersis disabled.For users that currently cannot log in (see #7429 and #7405) you'll need to enable
Merge existing users.