Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max textarea height #6409

Merged
merged 6 commits into from
Mar 23, 2017
Merged

Max textarea height #6409

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1cd4dbf
wip
MartinSchoeler Mar 20, 2017
e958bc0
make the textarea respect a certain height
MartinSchoeler Mar 21, 2017
44faf19
fix wrong input
MartinSchoeler Mar 21, 2017
d37019c
remove leftover code
MartinSchoeler Mar 21, 2017
e51cae5
Merge remote-tracking branch 'origin/develop' into max-textarea-height
MartinSchoeler Mar 21, 2017
6cd28a8
Merge remote-tracking branch 'origin/max-textarea-height' into max-te…
MartinSchoeler Mar 21, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/rocketchat-theme/client/imports/base.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2371,7 +2371,8 @@ label.required::after {
padding-bottom: 9px;
padding-left: 49px;
border-radius: 0;
overflow-y: hidden;
overflow-y: auto;
max-height: 155px;
resize: none;
line-height: 16px;
border-width: 0 1px 0 0;
Expand Down
1 change: 1 addition & 0 deletions packages/rocketchat-ui/client/lib/textarea-autogrow.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
var self = this;
var $self = $(self);
var minHeight = $self.height();
var maxHeight = minHeight * 5;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where do you use maxHeight?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is leftover code, removed now.

var noFlickerPad = $self.hasClass('autogrow-short') ? 0 : parseInt($self.css('lineHeight')) || 0;
var settings = $.extend({
preGrowCallback: null,
Expand Down