Reactions setting #6285
Closed
Reactions setting #6285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kable-wilmoth
commented
Mar 8, 2017
| @@ -15,32 +15,21 @@ Meteor.startup(function() { | |||
| i18nLabel: 'API_Token' | |||
| }); | |||
|
|
|||
| this.add('SlackBridge_AliasFormat', '', { | |||
There was a problem hiding this comment.
Re-ordered the SlackBridge settings. Put the most probably used settings toward the top
kable-wilmoth
commented
Mar 8, 2017
| type: 'boolean', | ||
| enableQuery: { | ||
| _id: 'SlackBridge_Enabled', | ||
| value: true | ||
| } | ||
| }, | ||
| i18nLabel: 'Reactions' |
There was a problem hiding this comment.
I just re-used this i18nLabel
kable-wilmoth
commented
Mar 8, 2017
| @@ -13,6 +13,12 @@ class SlackBridge { | |||
| this.rocket.setSlack(this.slack); | |||
| this.slack.setRocket(this.rocket); | |||
|
|
|||
| //Settings that we cache versus looking up at runtime | |||
There was a problem hiding this comment.
Just added these here at the top for quick access to properties being used in SlackBridge
Introduced ES2015 Import/Export to resolve dependencies
kable-wilmoth
force-pushed
the
ReactionSetting
branch
from
159d19c to
3eb58ae
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes #6044
Closes RocketChat/feature-requests#620 (possibly)
Sorry, this PR is built on top of #6282, so if that one is accepted, then please focus on commit 159d19c
Added a setting to enable/disable reactions between slack and rocket