regression: Fix issue where marketplace would not fetch the apps

[Gustrb]

Proposed changes (including videos or screenshots)

Our old validation library would throw on error which was causing silent failures, now since we started using zod, we were able to catch this issue quite quickly.

Issue(s)

Steps to test or reproduce

Further comments

Introduced by https://rocketchat.atlassian.net/browse/CONN-492

CONN-530

[dionisio-bot]

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

[changeset-bot]

⚠️ No Changeset found

Latest commit: 9ca685a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.45%. Comparing base (282b2bf) to head (9ca685a).
Report is 1 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #35235   +/-   ##
========================================
  Coverage    59.45%   59.45%           
========================================
  Files         2828     2828           
  Lines        68159    68159           
  Branches     15124    15124           
========================================
  Hits         40521    40521           
  Misses       24982    24982           
  Partials      2656     2656           

Flag	Coverage Δ
unit	75.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[MarcosSpessatto]

If its a regression, please add the PR which introduced the problem please.

[Gustrb]

Done

[thepiyush-303]

I fetched your branch and tried to test out the marketplace but got the same error, unsupported version

ERROR (Rocket.Chat Apps/79623 on Piyush-Linux): Failed to fetch marketplace apps {"errorMsg":"unsupported version"}

what am I missing?

[Gustrb]

unsuported version is not the same error, it happens due to your workspace being in a unsupported version. Which comes from cloud

[thepiyush-303]

Okay, How do i change my version so that it can support deploying rc- apps.

[Gustrb]

I would test using branch 7.3.0 or just sync your workspace. should do the trick

[thepiyush-303]

I would test using branch 7.3.0 or just sync your workspace. should do the trick

okay, it will not work on latest version, right?

[Gustrb]

I assume there is something fishy with your deployment, but I believe you should open an issue if you can't get it to work

[thepiyush-303]

while deploying an Rc-App I land into:
rc-apps deploy --url http://localhost:3000 --username ThePiyush --password asdfasdf (node:91986) [DEP0040] DeprecationWarning: Thepunycodemodule is deprecated. Please use a userland alternative instead. (Usenode --trace-deprecation ...` to show where the warning was created)
Starting App Deployment to Server

Getting Server Info... ✓
2025-02-19 00:20:54.385 WARN App has external module(s) as dependency
(node:91986) [DEP0044] DeprecationWarning: The util.isArray API is deprecated. Please use Array.isArray() instead.
(node:91986) [DEP0047] DeprecationWarning: The util.isDate API is deprecated. Please use arg instanceof Date instead.
Packaging the app... ✓
Uploading App... ✖
› Error: ⟿ Error: Deployment error: [3ae38cf4-3812-4e59-ac19-e8c0968b150c] Timeout: app process not ready
`

I thought there is some problem with marketplace apps fetching.
and also getting this with a fresh clone:

still don't know how i can get it fix :(

[Gustrb]

Hard to say without much info. But rc-apps deploy shouldn’t have anything to do with this PR
Please open an issue

[thepiyush-303]

okay Got it,
Thankyou very much for the guidance.
Also I have some PR raised one of them is also reviewed by you, if you got some time please give some feedback on them.

PR -> #34899
Thanks.

[github-actions]

PR Preview Action v1.6.0
🚀 View preview at https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35235/
Built to branch gh-pages at 2025-02-19 12:44 UTC. Preview will be ready when the GitHub Pages deployment is complete.

[KevLehman]

@thepiyush-303 , please open an issue with that. But please make sure you have Deno installed on the right version before opening the issue. Thanks!

[thepiyush-303]

Hello @KevLehman ,Just find out my deno version and it was above 2 (don't know when it changed), but now it is fixed and showing apps to me.
Thankyou.