-
Notifications
You must be signed in to change notification settings - Fork 11.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Moves getUserDisplayName
outside from meteor app
#35031
Conversation
Looks like this PR is ready to merge! 🎉 |
|
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #35031 +/- ##
===========================================
+ Coverage 59.43% 59.47% +0.03%
===========================================
Files 2826 2828 +2
Lines 68170 68290 +120
Branches 15129 15148 +19
===========================================
+ Hits 40520 40616 +96
- Misses 24993 25016 +23
- Partials 2657 2658 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
getUserDisplayName
outside from meteor appgetUserDisplayName
outside from meteor app
1c4c436
to
31ed52f
Compare
31ed52f
to
435f43e
Compare
This PR currently has a merge conflict. Please resolve this and then re-add the |
0515e81
to
61cf06e
Compare
Proposed changes (including videos or screenshots)
It moves the auxiliary
getUserDisplayName
function tocore-typings
anduseUserDisplayName
hook toui-client
in order to give more flexibility to use them outside from meteor appIssue(s)
Steps to test or reproduce
Further comments