Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Revive Livechat Storybook #33137

Merged
merged 2 commits into from
Aug 23, 2024
Merged

chore: Revive Livechat Storybook #33137

merged 2 commits into from
Aug 23, 2024

Conversation

MartinSchoeler
Copy link
Contributor

@MartinSchoeler MartinSchoeler commented Aug 23, 2024 •
edited
Loading

CORE-646

Apparently we weren't handling .mjs properly after the TS conversions, also there was a typeguard that was removing data instead of only guaranteeing the Types

@dionisio-bot dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Aug 23, 2024 •
edited
Loading

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 6.13.0, but it targets 6.12.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 23, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 02a00d3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MartinSchoeler MartinSchoeler added this to the 6.13 milestone Aug 23, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.33%. Comparing base (c2609d7) to head (02a00d3).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33137   +/-   ##
========================================
  Coverage    59.33%   59.33%           
========================================
  Files         2548     2548           
  Lines        63320    63320           
  Branches     14248    14269   +21     
========================================
  Hits         37570    37570           
  Misses       23043    23043           
  Partials      2707     2707
Flag Coverage Δ
unit 75.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@MartinSchoeler MartinSchoeler marked this pull request as ready for review August 23, 2024 13:57
@MartinSchoeler MartinSchoeler requested review from a team as code owners August 23, 2024 13:57
dougfabris
dougfabris approved these changes Aug 23, 2024
View reviewed changes
Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dougfabris dougfabris added the stat: QA assured Means it has been tested and approved by a company insider label Aug 23, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Aug 23, 2024
@tassoevan
Copy link
Contributor

@kodiakhq kodiakhq bot merged commit eaf9c8d into develop Aug 23, 2024
49 checks passed
@kodiakhq kodiakhq bot deleted the livechat-storybook branch August 23, 2024 15:46
gabriellsh added a commit that referenced this pull request Sep 2, 2024
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into impr…
e9b49ff 
…ove/threadMetrics

* 'develop' of github.com:RocketChat/Rocket.Chat: (49 commits)
  feat: add `sidepanelNavigation` to Feature preview list (#33156)
  refactor: Realtime Monitoring Counters to TS (#33182)
  fix: restore tooltips to units Multiselect (#33174)
  test: Add unit test for RoomMenu options (#32891)
  chore: remove notifyListener call that was causing startup issues (#33154)
  fix: Multi-step modals closing unexpectedly (#33158)
  Revert "refactor: Realtime Monitoring Counters to TS" (#33170)
  refactor: Realtime Monitoring Counters to TS (#33166)
  refactor: Uses `source` instead of `room` to render the `OmnichannelRoomIcon` (#33118)
  refactor: Realtime Monitoring Overviews to TS (#33167)
  test: Add e2e tests for teams multi-step modals (#33168)
  feat: add Advanced settings accordion to `EditRoomInfo` (#33114)
  chore: Revive Livechat Storybook (#33137)
  refactor: Realtime `Doughnout Charts` to TS (#33092)
  feat: create contact endpoint (#32693)
  chore: remove left streaming code (#33039)
  fix: show only relevant userInfoActions for mentioned non-members (#31525)
  feat: Setting for enabling files encryption and fix whitelist media types stopping E2EE uploads (#33003)
  refactor: Replace proxy functions from `LivechatTyped` class with direct calls (#33110)
  Revert "fix: Inconsistent Markdown Formatting in Custom Status Field" (#33127)
  ...
abhinavkrin pushed a commit that referenced this pull request Oct 25, 2024
@MartinSchoeler @abhinavkrin
chore: Revive Livechat Storybook (#33137)
0b60dcb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tassoevan tassoevan tassoevan approved these changes

@dougfabris dougfabris dougfabris approved these changes

Assignees
No one assigned
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Milestone
6.13
Development

Successfully merging this pull request may close these issues.
3 participants
@MartinSchoeler @tassoevan @dougfabris