Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: ResetButton misaligned on BooleanSettingInput #31236

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

dougfabris
Copy link
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link

changeset-bot bot commented Dec 13, 2023

⚠️ No Changeset found

Latest commit: 2eb11b4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dougfabris dougfabris added this to the 6.6 milestone Dec 13, 2023
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Merging #31236 (2eb11b4) into develop (d143fb6) will decrease coverage by 28.47%.
The diff coverage is 50.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop   #31236       +/-   ##
============================================
- Coverage    77.39%   48.92%   -28.47%     
============================================
  Files          276     3270     +2994     
  Lines         8716    80351    +71635     
  Branches      1616    16391    +14775     
============================================
+ Hits          6746    39315    +32569     
- Misses        1563    36387    +34824     
- Partials       407     4649     +4242     
Flag Coverage Δ
e2e 51.47% <50.00%> (∅)
e2e-api 40.68% <ø> (?)
unit 77.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris dougfabris marked this pull request as ready for review December 14, 2023 12:50
@dougfabris dougfabris requested a review from a team as a code owner December 14, 2023 12:50
@ggazzo ggazzo merged commit f15577f into develop Dec 14, 2023
@ggazzo ggazzo deleted the regression/booleanSettingInput branch December 14, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants