Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Re-add the eye-off icon #12079

Merged
merged 1 commit into from
Sep 17, 2018
Merged

[FIX] Re-add the eye-off icon #12079

merged 1 commit into from
Sep 17, 2018

Conversation

MIKI785
Copy link
Contributor

@MIKI785 MIKI785 commented Sep 16, 2018

This PR simply re-adds the eye-off icon that was previously part of icons.svg but is now missing resulting in a missing icon in the 'Hide' , 'Hide Room' and 'Unread on Top' buttons.

Before:
image
image

After:
image
image

Closes #12002

@sampaiodiego
Copy link
Member

Thank you.. Much appreciated. 😄

@sampaiodiego sampaiodiego merged commit 112f54e into RocketChat:develop Sep 17, 2018
@MIKI785 MIKI785 deleted the hide-icon branch September 18, 2018 10:17
engelgabriel added a commit that referenced this pull request Sep 19, 2018
* develop: (27 commits)
  Fix stylelint
  [FIX]  Login error message not obvious if user not activated (#11785)
  [NEW] REST endpoints to get moderators from groups and channels (#11909)
  [NEW] User preference for 24- or 12-hour clock (#11169)
  [FIX] Adding scroll bar to read receipts modal (#11919)
  [FIX] Fixing translation on 'yesterday' word when calling timeAgo function (#11946)
  [FIX] Fixing spacement between tags and words on some labels (#12018)
  [FIX] video message recording, issue #11651 (#12031)
  [FIX] Prevent form submission in Files List search (#11999)
  [NEW] REST endpoint to set groups' announcement (#11905)
  [FIX] Re-add the eye-off icon (#12079)
  [NEW] Livechat trigger option to run only once (#12068)
  [IMPROVE] Use eslint-config package (#12044)
  [FIX] Internal error when cross-origin with CORS is disabled (#11953)
  [FIX] Message reaction in GraphQL API (#11967)
  [FIX] Direct messages leaking into logs (#11863)
  Fix the stylelint (#11991)
  [NEW] REST endpoints to create roles and assign roles to users (#11855)
  [FIX] Hidden admin sidenav on embedded layout (#12025)
  [FIX] Update user information not possible by admin if disabled to users (#11955)
  ...

# Conflicts:
#	package-lock.json
#	package.json
This was referenced Sep 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants