[FIX] Slack importer: image previews not showing #11875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR tackles the issue of images not being loaded to chat window after importing from slack. The issue remained as because of some updates on the slack's export data format(json). This PR will however support both the export data formats (the order |
|
@Hudell please look into the PR |
|
Don't want to be impatient, but any idea when this PR is going to be in a release? |
Hudell
previously approved these changes
Oct 1, 2018
sampaiodiego
approved these changes
Oct 20, 2018
sampaiodiego
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11874 #10278