Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NEW] Internal marketplace for apps #11864

Merged
merged 35 commits into from
Aug 28, 2018
Merged

[NEW] Internal marketplace for apps #11864

merged 35 commits into from
Aug 28, 2018

Conversation

rodrigok
Copy link
Member

@rodrigok rodrigok commented Aug 24, 2018 •
edited
Loading

localhost_3000_admin_apps_4e28f03b-054b-4ce3-9573-fd8a6bcbecf6 laptop with hidpi screen
localhost_3000_admin_apps_4e28f03b-054b-4ce3-9573-fd8a6bcbecf6 laptop with hidpi screen 1
localhost_3000_admin_apps_4e28f03b-054b-4ce3-9573-fd8a6bcbecf6 laptop with hidpi screen 2

gdelavald and others added 26 commits August 21, 2018 16:45
@gdelavald @rssilva
Update page details
caf247f
@gdelavald @rssilva
Adds icon to marketplace install button
6392b80
@gdelavald @rssilva
Add icon and animation for installing apps
0c2950a
@gdelavald @rssilva
Fixes animation svg for app installation
0f71101
@gdelavald @rssilva
Changes to actions
8f09025
@rssilva
Fixing conflicts
915661b
@rssilva
Adding the right return to apps()
e2663bf
@rssilva
Fetching apps according tab context ('marketplace' or 'installed')
5d5e991
@rssilva
Set loading on tables
469e67e
@rssilva
Adding POST to install the app on click
33898a3
@rssilva
Fixing linting
4190a87
@rssilva
Tagging already installed apps with prop '_installed' to show the 'v'…
94df7d4 
… icon
@rssilva
Adding helper to render the 'v' icon when the app is already downloaded
2056012
@rssilva
Commenting _appOnAppAdded method for now
926d511
@rssilva
Fixing arrow functions returning objects
aad32f8
@rssilva
Adding isInstalled helper to appManage to hide 'install' button on de…
d38c481 
…tails page
@rssilva
Linting
0953304
@rssilva
Fixing event propagation on table, adding uninstall button
dfb4fb7
@rssilva
Removing unnecessary comments
b7cd44e
@rodrigok
Fix missing image for isntalled apps
c96ad25
@rodrigok
Add translation for Apps_Details
6b6cadf
@rodrigok
Improvements on app details screen
1a438ac
@rodrigok
Show categories for installed apps
acaf6ad
@rodrigok
Allow edit app settings
ea16ad6
@rodrigok
Improve app settings layout
45417d1
@rodrigok
Allow update apps
c7b94db
@rodrigok rodrigok added this to the 0.69.0 milestone Aug 24, 2018
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-11864 August 24, 2018 20:10 Inactive
@rodrigok rodrigok requested a review from ggazzo August 24, 2018 20:20
@RocketChat RocketChat deleted a comment Aug 27, 2018
@RocketChat RocketChat deleted a comment Aug 27, 2018
@RocketChat RocketChat deleted a comment Aug 27, 2018
@RocketChat RocketChat deleted a comment Aug 27, 2018
@RocketChat RocketChat deleted a comment Aug 27, 2018
@RocketChat RocketChat deleted a comment Aug 27, 2018
@RocketChat RocketChat deleted a comment Aug 27, 2018
@RocketChat RocketChat deleted a comment Aug 27, 2018
@RocketChat RocketChat deleted a comment Aug 27, 2018
@RocketChat RocketChat deleted a comment Aug 27, 2018
@RocketChat RocketChat deleted a comment Aug 27, 2018
@RocketChat RocketChat deleted a comment Aug 27, 2018
@RocketChat RocketChat deleted a comment Aug 27, 2018
@RocketChat RocketChat deleted a comment Aug 27, 2018
@RocketChat RocketChat deleted a comment Aug 27, 2018
@RocketChat RocketChat deleted a comment Aug 27, 2018
@RocketChat RocketChat deleted a comment Aug 27, 2018
@RocketChat RocketChat deleted a comment Aug 27, 2018
@RocketChat RocketChat deleted a comment Aug 27, 2018
@RocketChat RocketChat deleted a comment Aug 27, 2018
ggazzo
ggazzo approved these changes Aug 27, 2018
View reviewed changes
Copy link
Member

@ggazzo ggazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to change few things in the future, but good for now. :x

@sampaiodiego sampaiodiego merged commit c15d3ca into develop Aug 28, 2018
@sampaiodiego sampaiodiego deleted the apps-marketplace-final branch August 28, 2018 00:07
@sampaiodiego sampaiodiego mentioned this pull request Aug 28, 2018
Merged
@vynmera vynmera mentioned this pull request Aug 31, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggazzo ggazzo ggazzo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.69.0
Development

Successfully merging this pull request may close these issues.
6 participants
@rodrigok @ggazzo @engelgabriel @sampaiodiego @gdelavald @rssilva