Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Fixing timeAgo function on directory #11728

Merged
merged 2 commits into from
Aug 13, 2018
Merged

[FIX] Fixing timeAgo function on directory #11728

merged 2 commits into from
Aug 13, 2018

Conversation

rssilva
Copy link
Contributor

@rssilva rssilva commented Aug 9, 2018

Fix #11663

Adding timeAgo function to a helpers file so we can test it because just importing it from the previous file will cause an error Template is not defined. I reproduced the mentioned case on a test.

@rssilva rssilva self-assigned this Aug 9, 2018
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-11728 August 9, 2018 17:05 Inactive
@ggazzo ggazzo added the ui/ux label Aug 10, 2018
@ggazzo ggazzo added this to the 0.69.0 milestone Aug 10, 2018
@ggazzo ggazzo requested review from ggazzo and tassoevan August 10, 2018 20:09
@ggazzo ggazzo merged commit 94ad01f into develop Aug 13, 2018
@ggazzo ggazzo deleted the fix-directory-showing-dates branch August 13, 2018 19:12
@sampaiodiego sampaiodiego mentioned this pull request Aug 28, 2018
Merged
@tahajahangir
Copy link

@rssilva
The "yesterday" word was translated with t('yesterday'), but after this PR, it's the english word 'yesterday' in any language.

@rssilva
Copy link
Contributor Author

rssilva commented Sep 3, 2018

@tahajahangir oh thank you for the heads up! I'll open a PR ASAP 😃

@rssilva rssilva mentioned this pull request Sep 4, 2018
Merged
@rssilva
Copy link
Contributor Author

rssilva commented Sep 4, 2018

here we go #11946

ggazzo pushed a commit that referenced this pull request Sep 18, 2018
@rssilva @ggazzo
[FIX] Fixing translation on 'yesterday' word when calling timeAgo fun…
bf68f96 
…ction (#11946)

Related with #11663, but I added a bug removing `t` function on this PR 😬 #11728

Now we're translating 🗣 🌎 🌍 🌏 

![screen shot 2018-09-04 at 10 20 55 am](https://user-images.githubusercontent.com/2047941/45033836-30e28000-b02c-11e8-8726-96d8780eb92b.png)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggazzo ggazzo ggazzo approved these changes

@tassoevan tassoevan tassoevan approved these changes

Assignees

@rssilva rssilva

Labels
ui/ux
Projects
None yet
Milestone
0.69.0
Development

Successfully merging this pull request may close these issues.
5 participants
@rssilva @tahajahangir @tassoevan @ggazzo @engelgabriel