[FIX] Searching by undefined via REST when using query param
#11657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…id searches by undefined
| @@ -44,7 +44,7 @@ RocketChat.API.helperMethods.set('parseJsonQuery', function _parseJsonQuery() { | |||
| } | |||
| } | |||
|
|
|||
| let query; | |||
| let query = {}; | |||
There was a problem hiding this comment.
with this change I guess the test on line 58 isn't required anymore, right?
There was a problem hiding this comment.
Wrong, since JSON.parse('false'); can generate query = false;
rodrigok
approved these changes
Aug 20, 2018
sampaiodiego
changed the title
query param
sampaiodiego
changed the title
query paramundefined via REST when using query param
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11636
Closes #11599
Closes #11760