Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Fix links in onTableItemClick of the directroy page #11543

Merged
merged 7 commits into from
Aug 20, 2018

Conversation

ura14h
Copy link
Contributor

@ura14h ura14h commented Jul 22, 2018

Fix that subdir routing on the directory page is duplicated.

Related #10732.

I use 0.65.1 with sub directory. (e.g. /apps/chat/ )
To open a channel from the left side bar works fine. This link is /apps/chat/channel/general.
But to open a channel from directory page is fail. I seem URL in directory page is incorrect. This broken link is /apps/chat/apps/chat/channel/general.

Excuse me, This PR cannot fix all of #10732.

@RocketChat RocketChat deleted a comment Jul 22, 2018
@ura14h
Copy link
Contributor Author

ura14h commented Jul 26, 2018

After executing 'Update Branch', some CI tests failed. It seems that my patch is not the cause, but does I need to take some actions?

@serviceman
Copy link

This is the last bug I have been waiting to be fixed to release this chat to my chat community. Does anyone know when this should be added to the master?

@ggazzo ggazzo added the ui/ux label Aug 6, 2018
@ggazzo ggazzo added this to the 0.69.0 milestone Aug 6, 2018
@ura14h
Copy link
Contributor Author

ura14h commented Aug 15, 2018

Before to close this, please check PR #11781.

@ggazzo ggazzo merged commit f71b740 into RocketChat:develop Aug 20, 2018
@serviceman
Copy link

When will this fix be added to the production release?

@sampaiodiego sampaiodiego mentioned this pull request Aug 28, 2018
@ura14h ura14h deleted the ura14-patch-directory branch October 17, 2018 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants