Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Render reply preview with message as a common message #11534

Merged
merged 1 commit into from
Jul 21, 2018
Merged

[FIX] Render reply preview with message as a common message #11534

merged 1 commit into from
Jul 21, 2018

Conversation

tassoevan
Copy link
Contributor

@tassoevan tassoevan commented Jul 20, 2018 •
edited
Loading

Before

before

After

after

@tassoevan tassoevan changed the title [IMPROVERender reply preview with message as a common message [IMPROVE] Render reply preview with message as a common message Jul 20, 2018
@tassoevan tassoevan requested a review from ggazzo July 20, 2018 20:41
@tassoevan tassoevan changed the title [IMPROVE] Render reply preview with message as a common message [FIX] Render reply preview with message as a common message Jul 20, 2018
@tassoevan tassoevan added this to the 0.68.0 milestone Jul 20, 2018
@sampaiodiego sampaiodiego merged commit 0ca1a2b into develop Jul 21, 2018
@sampaiodiego sampaiodiego deleted the improve.reply-preview-style branch July 21, 2018 05:04
@sampaiodiego sampaiodiego mentioned this pull request Jul 28, 2018
Merged
@Vacak7
Copy link

Vacak7 commented Aug 8, 2018

Dear All,
Can we render the new replies under the original messages? Is there a way to modify the DOM to render it there?

@tassoevan
Copy link
Contributor Author

@Vacak7 I guess you're talking about threads.

@Vacak7
Copy link

Vacak7 commented Aug 8, 2018

@tassoevan I was talking about that: https://forums.rocket.chat/t/change-reply-place-in-conversation/1193

@Vacak7
Copy link

Vacak7 commented Aug 9, 2018

@engelgabriel @tassoevan
Can you tell me; why the message reply was designed like this?

image

Why is that the reverse? Is there any way to change it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggazzo ggazzo ggazzo approved these changes

Assignees
No one assigned
Labels
type: bug ui/ux
Projects
None yet
Milestone
0.68.0
Development

Successfully merging this pull request may close these issues.
5 participants
@tassoevan @Vacak7 @ggazzo @engelgabriel @sampaiodiego