-
Notifications
You must be signed in to change notification settings - Fork 11.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NEW] Run CircleCI with and without Apps Framework enabled #10707
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order for the new jobs to run you have to add them into workflows
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will be converting this to a setting, so let's not merge this as it will need another change in the future.
@graywolf336 I think we can merge it anyway, there's no problem in changing it later and it may be able to detect a few problems like the one we had this week. |
Can you fill me in? I wasn't aware of an issue related to Apps. |
Do we still want this? Or should we close this out? |
idk.. we had an issue at some point that happened only with apps enabled.. but I'm not sure how buggy it's right now that we would still need this. |
@rodrigok wdyt? |
@sampaiodiego It's important. |
Changes CircleCI configuration to run the tests with and without the Apps Framework