Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Add internal API to handle room announcements #10396

Merged
merged 5 commits into from
Apr 16, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
116 changes: 58 additions & 58 deletions package-lock.json

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,9 @@ Template.channelSettingsEditing.onCreated(function() {
announcement: {
type: 'markdown',
label: 'Announcement',
getValue() {
return Template.instance().room.announcement && Template.instance().room.announcement.message;
},
canView() {
return RocketChat.roomTypes.roomTypes[room.t].allowRoomSettingChange(room, RoomSettingsEnum.ANNOUNCEMENT);
},
Expand Down Expand Up @@ -450,7 +453,7 @@ Template.channelSettingsInfo.helpers({
return Template.instance().room.description;
},
announcement() {
return Template.instance().room.announcement;
return Template.instance().room.announcement ? Template.instance().room.announcement.message : '';
},
topic() {
return Template.instance().room.topic;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,16 @@ RocketChat.saveRoomAnnouncement = function(rid, roomAnnouncement, user, sendMess
if (!Match.test(rid, String)) {
throw new Meteor.Error('invalid-room', 'Invalid room', { function: 'RocketChat.saveRoomAnnouncement' });
}
const announcementObject = typeof roomAnnouncement === 'object' ?
roomAnnouncement :
{
message: roomAnnouncement
};

roomAnnouncement = s.escapeHTML(roomAnnouncement);
const updated = RocketChat.models.Rooms.setAnnouncementById(rid, roomAnnouncement);
const escapedMessage = s.escapeHTML(announcementObject.message);
const updated = RocketChat.models.Rooms.setAnnouncementById(rid, {...announcementObject, message: escapedMessage});
if (updated && sendMessage) {
RocketChat.models.Messages.createRoomSettingsChangedWithTypeRoomIdMessageAndUser('room_changed_announcement', rid, roomAnnouncement, user);
RocketChat.models.Messages.createRoomSettingsChangedWithTypeRoomIdMessageAndUser('room_changed_announcement', rid, escapedMessage, user);
}

return updated;
Expand Down
21 changes: 21 additions & 0 deletions packages/rocketchat-lib/client/lib/RocketChatAnnouncement.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
export class RocketChatAnnouncement {
constructor(args={}) {
this.room = new ReactiveVar(args.room);
this.message = new ReactiveVar(args.message);
this.callback = new ReactiveVar(args.callback);
this.style = new ReactiveVar(args.style);
}
save() {
const announcementObject = { message: this.message.get(), callback: this.callback.get(), style: this.style.get() };
Meteor.call('saveRoomSettings', this.room.get(), 'roomAnnouncement', announcementObject);
}
getMessage() {
return this.message.get();
}
getCallback() {
return this.callback.get();
}
getStyle() {
return this.callback.get();
}
}
4 changes: 3 additions & 1 deletion packages/rocketchat-lib/client/lib/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
*/

import { RocketChatTabBar } from './RocketChatTabBar';
import { RocketChatAnnouncement } from './RocketChatAnnouncement';
import { RoomSettingsEnum, RoomTypeConfig, RoomTypeRouteConfig, UiTextContext } from '../../lib/RoomTypeConfig';
import { hide, leave, erase } from './ChannelActions';
import { call } from './callMethod';
Expand All @@ -20,5 +21,6 @@ export {
RoomSettingsEnum,
RoomTypeConfig,
RoomTypeRouteConfig,
UiTextContext
UiTextContext,
RocketChatAnnouncement
};
1 change: 1 addition & 0 deletions packages/rocketchat-lib/package.js
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,7 @@ Package.onUse(function(api) {
api.addFiles('client/lib/RestApiClient.js', 'client');
api.addFiles('client/lib/TabBar.js', 'client');
api.addFiles('client/lib/RocketChatTabBar.js', 'client');
api.addFiles('client/lib/RocketChatAnnouncement.js', 'client');
api.addFiles('client/lib/RestApiClient.js', 'client');
api.addFiles('client/lib/cachedCollection.js', 'client');
api.addFiles('client/lib/openRoom.js', 'client');
Expand Down
6 changes: 6 additions & 0 deletions packages/rocketchat-theme/server/colors.less
Original file line number Diff line number Diff line change
Expand Up @@ -950,4 +950,10 @@ label.required::after {

.announcement {
background-color: @primary-background-color;
&.warning {
background-color: var(--rc-color-alert);
}
&.error {
background-color: var(--rc-color-alert-message-warning);
}
}
2 changes: 1 addition & 1 deletion packages/rocketchat-ui/client/views/app/room.html
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
<div class="messages-container-main">
{{#unless embeddedVersion}}
{{#if showAnnouncement}}
<div class="fixed-title announcement" aria-label="{{RocketChatMarkdown roomAnnouncement}}">
<div class="fixed-title announcement {{getAnnouncementStyle}}" aria-label="{{RocketChatMarkdown roomAnnouncement}}">
{{{RocketChatMarkdown roomAnnouncement}}}
</div>
{{/if}}
Expand Down
32 changes: 23 additions & 9 deletions packages/rocketchat-ui/client/views/app/room.js
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ Template.room.helpers({
showAnnouncement() {
const roomData = Session.get(`roomData${ this._id }`);
if (!roomData) { return false; }
return (roomData.announcement !== undefined) && (roomData.announcement !== '');
return (roomData.announcement !== undefined) && (roomData.announcement.message !== '');
},

messageboxData() {
Expand All @@ -235,7 +235,13 @@ Template.room.helpers({
roomAnnouncement() {
const roomData = Session.get(`roomData${ this._id }`);
if (!roomData) { return ''; }
return roomData.announcement;
return roomData.announcement && roomData.announcement.message;
},

getAnnouncementStyle() {
const roomData = Session.get(`roomData${ this._id }`);
if (!roomData) { return ''; }
return roomData.announcement && roomData.announcement.style !== undefined ? roomData.announcement.style : '';
},

roomIcon() {
Expand Down Expand Up @@ -704,13 +710,21 @@ Template.room.events({
}
},
'click .announcement'(e) {
modal.open({
title: t('Announcement'),
text: $(e.target).attr('aria-label'),
showConfirmButton: false,
showCancelButton: true,
cancelButtonText: t('Close')
});
const roomData = Session.get(`roomData${ this._id }`);
if (!roomData) { return false; }
if (roomData.announcement !== undefined && roomData.announcement.callback !== undefined) {
return RocketChat.callbacks.run(roomData.announcement.callback, this._id);
} else {
modal.open({
title: t('Announcement'),
text: $(e.target).attr('aria-label'),
showConfirmButton: false,
showCancelButton: true,
cancelButtonText: t('Close')
});

}

}
});

Expand Down