[NEW] Support for dynamic slack and rocket.chat channels #10205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at into dynamic-groups
|
@Hudell can you fix the conflict? |
engelgabriel
previously requested changes
Jun 11, 2018
| }); | ||
|
|
||
| Npm.depends({ | ||
| 'slack-client': '2.0.6' |
There was a problem hiding this comment.
Why are we adding this here?
rodrigok
reviewed
Jun 19, 2018
| } | ||
| //Choose whether SlackBridge should also send your messages back to Slack | ||
| RocketChat.settings.get('SlackBridge_Out_Enabled', (key, value) => { | ||
| logger.class.debug(`Setting: ${ key }`, value); |
| this.copySlackChannelInfo(rid, this.slackChannelMap[rid]); | ||
| //Send messages from all channels that exist in Slack and the bot has joined | ||
| RocketChat.settings.get('SlackBridge_Out_All', (key, value) => { | ||
| logger.class.debug(`Setting: ${ key }`, value); |
| } | ||
| //Choose which channels will send messages back to Slack | ||
| RocketChat.settings.get('SlackBridge_Out_Channels', (key, value) => { | ||
| logger.class.debug(`Setting: ${ key }`, value); |
rodrigok
approved these changes
Jun 19, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes an item on #8012 , merging PR #6282
Also closes #6509
Original description: