Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Web App Manifest origin incorrect, icon images reference wrong path #9990

Closed
justinribeiro opened this issue Mar 3, 2018 · 1 comment · Fixed by #9991
Closed

[BUG] Web App Manifest origin incorrect, icon images reference wrong path #9990

justinribeiro opened this issue Mar 3, 2018 · 1 comment · Fixed by #9991

Comments

@justinribeiro
Copy link
Contributor

Description:

Currently the web app manifest definition located at public/images/manifest.json contains two errors as reported by Google Chrome DevTools:

  1. Manifest: property 'start_url' ignored, should be same origin as document.
  2. Icon downloaded from the manifest was empty or corrupted

Expected behavior:

The manifest should allow the application to be added to the home screen on Android or other platforms that support the Web App Manifest API specification.

Actual behavior:

  1. Google Chrome for Android will install the incorrect icon on the homescreen.
  2. Mozilla Firefox for Android will not properly prompt for homescreen addition.

Relevant logs:

image

@christianprim
Copy link

christianprim commented Jun 8, 2018

manifest.json should look like this:
{ "name": "Rocket.Chat", "icons": [ { "src": "\/assets\/favicon_192.png", "sizes": "192x192", "type": "image\/png" }, { "src": "\/assets\/favicon_512.png", "sizes": "512x512", "type": "image\/png" } ], "start_url": "\/home", "display": "standalone" }
icon-src must be absolute. start_url relative.

ggazzo pushed a commit that referenced this issue Jul 5, 2018
@RocketChat/core 

Closes #9990

This pull request properly brings the web app manifest up-to-date to the current specification and resolves the incorrect start_url origin and the path to the broken images as seen in this screenshot.

This resolves the unwanted and incorrect behavior experienced in both Google Chrome and Mozilla Firefox for Android.

![image](https://user-images.githubusercontent.com/643503/36929663-052fe33c-1e49-11e8-8a68-3d8e666d30e8.png)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants