feat: troubleshoot notification #5198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnlsilva
suggested changes
Sep 20, 2023
app/lib/constants/colors.ts
Outdated
| @@ -12,6 +12,15 @@ export const SWITCH_TRACK_COLOR = { | |||
| true: '#2de0a5' | |||
| }; | |||
|
|
|||
| const pushTroubleshooting = { | |||
| pushConsumptionOnSuccess: '#148660', | |||
There was a problem hiding this comment.
I understand, but there are already successColor and dangerColor in this file, if I just added onSuccess or onDanger it would be weird. The dangerColor is used in other places of the app and the difference between the names will be minimal, but there is a difference between the colors. WDYT?
There was a problem hiding this comment.
It's not strange, the right thing is to correct the mistake of the past and not make the same mistake again because it was wrong in the past.
There was a problem hiding this comment.
Even a good thing would be to check the colors used in figma, Jose is using some deprecated colors, you could ask him to change and use the colors that are already in the new design system.
reinaldonetof
changed the base branch from
develop
to
TC-782-Mobile-Troubleshoot-notifications
dnlsilva
approved these changes
Sep 28, 2023
dnlsilva
added a commit
that referenced
this pull request
Mar 4, 2024
* feat: troubleshoot notification (#5198) * navigation done * create the icon inside roomslistview, navigation to push troubleshot and layout push troubleshoot * custom header * fix the rooms list view header icon * layout done * update the pt-br i18n * tweak on colors * feat: create notification in room view (#5250) * button and simple navigation done, missing master detail * navigation * add withTheme and colors to rightuttons * fix e2e test * feat: add troubleshooting to notifications pages (#5276) * feat: add troubleshooting to notifications pages * fix e2e test * feat: device notification settings (#5277) * iOS go to device notification setting to change the configuration * go to notification settings with android * add notifee * add the reducer and action * saga request done * add the setInAlert action * tweak at name and add focus to dispatch the request * use the foreground inside pushTroubleShoot to request the notification and fix the icon color * add the request at roomslistview didmount * remove the notification modulo from android * add patch * minor tweak * feat: test push notification (#5329) * feat: test push notification * restApi and definition * push.info and change properly the troubleshootingNotification * use the finally at try/catch * minor tweak * alert and push.info just for 6.6 * fix the react-native.config * minor tweaks * minor tweak * push.test as rest api * change the name from inAlertNotification to highlightTroubleshooting * feat: push quota * refactor the percentage state * removed the push quota feature * minor tweaks * update the link to push notification * the notification icon in the room header will appear if notifications are disabled or highlight troubleshoot is true * remove push quota texts * updated some of the push quota texts * chore: rename highlightTroubleshooting * chore: better prop naming * wip * chore: fix function name * chore: fix colors * fix: copy * chore: 💅 * chore: use fork * chore: naming * chore: fix init * chore: naming * chore: naming * Comment CE code * Use put on troubleshooting saga * Add db column * fix: check notification payload * action: organized translations * fix: push init --------- Co-authored-by: GleidsonDaniel <[email protected]> Co-authored-by: Diego Mello <[email protected]> Co-authored-by: GleidsonDaniel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Create the notifications button in the RoomListView and redirect the user to the troubleshooting page! Also the View's layout is done too.
Issue(s)
How to test or reproduce
Screenshots
Types of changes
Checklist
Further comments
TC-922