Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Make Mentions Interactive with User Detail Modal #680

Merged
merged 3 commits into from
Dec 22, 2024

Conversation

SinghaAnirban005
Copy link
Contributor

@SinghaAnirban005 SinghaAnirban005 commented Dec 5, 2024

Brief Title

Make Mentions Interactive with User Detail Modal

Acceptance Criteria fulfillment

  • Mentions in the chat input now trigger the user detail modal when clicked.

Fixes #689

Video/Screenshots

EmbeddedChat._.Simple.-.Simple.Storybook.-.Brave.2024-12-05.12-49-21.mp4

PR Test Details

Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-680 after approval. Contributors are requested to replace <pr_number> with the actual PR number.

@devanshkansagra
Copy link
Contributor

Hey @SinghaAnirban005, Please solve format issues

@devanshkansagra
Copy link
Contributor

Hey @SinghaAnirban005 instead of installing prettier package, run yarn run format at the root of this project and then check for any linting issues using yarn run lint. also discard this new commit

@Spiral-Memory Spiral-Memory merged commit fbb95b6 into RocketChat:develop Dec 22, 2024
8 checks passed
@thepiyush-303
Copy link
Contributor

@SinghaAnirban005
it shows userData is not a function to me.
can you help me.

@SinghaAnirban005
Copy link
Contributor Author

@thepiyush-303

  1. In packages/api , run yarn build
  2. then run the react project

@thepiyush-303
Copy link
Contributor

Thanks @SinghaAnirban005,
It worked now.

@Spiral-Memory Spiral-Memory added the chore a subtle fix label Jan 30, 2025
@Spiral-Memory Spiral-Memory changed the title Fix: Make Mentions Interactive with User Detail Modal chore: Make Mentions Interactive with User Detail Modal Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore a subtle fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mentions in Chat messages do not display user profile on Click
4 participants