Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph Horizontal Scrolling #142

Merged
merged 6 commits into from
Oct 19, 2019
Merged

Conversation

nbasargin
Copy link
Collaborator

This PR adds a native horizontal scrolling to the graph.

You need to hold Shift if you are scrolling with the mouse wheel (default browser behavior).
Scrolling is probably better on touch devices / trackpads.

I had to remove some CSS transitions due to conflicts with scrolling: scaling and adding new nodes is not animated anymore. This is fine since scaling is used not too often and animated insertion did move the complete graph, even if you didn't want it. Also, the SVG viewbox is gone. The graph won't resize automatically and you have full manual control over scale. Bigger screen is better.

The mock data panel can now be enabled for debugging. You can use the browser dev tools to show the debug button which toggles between chat and debug panel.

@codecov-io
Copy link

Codecov Report

Merging #142 into velvet-revolution will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@                  Coverage Diff                  @@
##           velvet-revolution     #142      +/-   ##
=====================================================
- Coverage              64.61%   64.57%   -0.05%     
=====================================================
  Files                     67       67              
  Lines                   4239     4245       +6     
=====================================================
+ Hits                    2739     2741       +2     
- Misses                  1500     1504       +4
Impacted Files Coverage Δ
modules/ravestate/causal.py 89.25% <0%> (-3.28%) ⬇️
modules/ravestate_nlp/yes_no.py 95.4% <0%> (+4.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1819dab...6eedd92. Read the comment docs.

@josephbirkner
Copy link
Collaborator

Works like a charm!

@josephbirkner josephbirkner merged commit 3d20937 into velvet-revolution Oct 19, 2019
@josephbirkner josephbirkner deleted the graph-scrolling branch October 22, 2019 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants