Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature extraction document for luigi #103

Merged
merged 7 commits into from
Jul 2, 2019

Conversation

umursen
Copy link
Collaborator

@umursen umursen commented Jun 14, 2019

No description provided.

@codecov-io
Copy link

codecov-io commented Jun 14, 2019

Codecov Report

Merging #103 into velvet-revolution will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                  @@
##           velvet-revolution    #103      +/-   ##
====================================================
+ Coverage              74.87%   74.9%   +0.02%     
====================================================
  Files                     56      56              
  Lines                   3495    3495              
====================================================
+ Hits                    2617    2618       +1     
+ Misses                   878     877       -1
Impacted Files Coverage Δ
modules/ravestate/constraint.py 92.1% <0%> (+0.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d233f9b...4ef8791. Read the comment docs.

Copy link
Collaborator

@josephbirkner josephbirkner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice summary 👍 Please merge this document (especially the Using the Features-Part) with ravestate_nlp/README.md. Examples would be good, especially for match_either_lemma() and reactions to combined signals. Thoughts @missxa ?

Copy link
Collaborator

@josephbirkner josephbirkner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it, but it is still missing a "deeper" connection to the docs.

I see the general value of this document as a hands-on tutorial how to approach NLP in connection with a specific use case.

Please:

  • ... link it into ravestate_nlp/README.md as Hands on: How to use ravestate_nlp to sell ice cream
  • Remove the Extracted Features table. This will just get outdated.

@josephbirkner josephbirkner merged commit 899cf91 into velvet-revolution Jul 2, 2019
@josephbirkner josephbirkner deleted the luigi_nlp_features_documentation branch July 2, 2019 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants