-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feature extraction document for luigi #103
Add feature extraction document for luigi #103
Conversation
Codecov Report
@@ Coverage Diff @@
## velvet-revolution #103 +/- ##
====================================================
+ Coverage 74.87% 74.9% +0.02%
====================================================
Files 56 56
Lines 3495 3495
====================================================
+ Hits 2617 2618 +1
+ Misses 878 877 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice summary 👍 Please merge this document (especially the Using the Features-Part) with ravestate_nlp/README.md. Examples would be good, especially for match_either_lemma() and reactions to combined signals. Thoughts @missxa ?
docs/general/sentence_processing_and_feature_extraction_techniques_for_luigi.md
Outdated
Show resolved
Hide resolved
docs/general/sentence_processing_and_feature_extraction_techniques_for_luigi.md
Outdated
Show resolved
Hide resolved
docs/general/sentence_processing_and_feature_extraction_techniques_for_luigi.md
Outdated
Show resolved
Hide resolved
docs/general/sentence_processing_and_feature_extraction_techniques_for_luigi.md
Outdated
Show resolved
Hide resolved
docs/general/sentence_processing_and_feature_extraction_techniques_for_luigi.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it, but it is still missing a "deeper" connection to the docs.
I see the general value of this document as a hands-on tutorial how to approach NLP in connection with a specific use case.
Please:
- ... link it into
ravestate_nlp/README.md
as Hands on: How to use ravestate_nlp to sell ice cream - Remove the
Extracted Features
table. This will just get outdated.
No description provided.