Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Windows documentation. #3685

Merged
merged 1 commit into from
Oct 5, 2016

Conversation

david-german-tri
Copy link
Contributor

@david-german-tri david-german-tri commented Oct 5, 2016

This change is Reviewable

@jwnimmer-tri
Copy link
Collaborator

FYI to any other readers, a mex -setup step got removed here also for all platforms, but it seems like a correct improvement.


Comments from Reviewable

@jwnimmer-tri
Copy link
Collaborator

:lgtm: :lgtm: :lgtm: :lgtm: :lgtm: :lgtm: :lgtm: :lgtm: :lgtm: :lgtm: :lgtm: :lgtm: :lgtm: :lgtm: :lgtm: :lgtm: :lgtm: :lgtm: :lgtm: :lgtm: :lgtm: :lgtm: :lgtm: :lgtm: :lgtm: :lgtm: :lgtm: :lgtm: :lgtm: :lgtm: :lgtm: :lgtm: :lgtm: :lgtm: :lgtm: :lgtm: :lgtm: :lgtm: :lgtm:


Reviewed 8 of 8 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@liangfok
Copy link
Contributor

liangfok commented Oct 5, 2016

There are numerous images in https://github.com/RobotLocomotion/drake/tree/master/drake/doc/images/windows_install. Should they be removed with this PR since this PR removes the .rst file that references them?


Review status: all files reviewed at latest revision, all discussions resolved, some commit checks pending.


Comments from Reviewable

@david-german-tri
Copy link
Contributor Author

Done.


Review status: 8 of 12 files reviewed at latest revision, all discussions resolved, some commit checks pending.


Comments from Reviewable

@jwnimmer-tri
Copy link
Collaborator

Reviewed 4 of 4 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks pending.


Comments from Reviewable

@liangfok
Copy link
Contributor

liangfok commented Oct 5, 2016

+@liangfok :lgtm:


Reviewed 8 of 8 files at r1, 4 of 4 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks pending.


Comments from Reviewable

@liangfok liangfok self-assigned this Oct 5, 2016
@jwnimmer-tri jwnimmer-tri merged commit f72451d into RobotLocomotion:master Oct 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants