-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the use of testUtil
from within drake/systems
#3276
Remove the use of testUtil
from within drake/systems
#3276
Conversation
Overall, this PR does a wonderful and significant cleanup. However, it also switches from measuring execution time in milliseconds to seconds. Has this change impacted measurement precision? It might if the user is saving the measured values in text log files since typically only a limited number of decimal places are saved. Thoughts? Why not use Reviewed 20 of 20 files at r1. Comments from Reviewable |
The units of reporting are changed, but the measurements are still done with sub-second precision. I ran the RBT benchmark before and after this edit, and the results were similar: Before:
After:
Given the above sample output, I don't think this is a concern.
When I quickly glanced at it, that clock did not appear to be guaranteed to be monotonic. Review status: all files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
In the spirit and recognition that we are in a sprint, I bestow upon this PR a
Review status: all files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
087827a
to
ffdefa7
Compare
Done. Review status: 20 of 21 files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
Reviewed 1 of 1 files at r2. CHANGELOG.md, line 26 [r2] (raw file):
BTW: nit: Surround C++ class / method names with back ticks so they appear in a different font, which indicate they are actual software artifacts. Also add a sentence saying the units changed from milliseconds to seconds. Comments from Reviewable |
Review status: all files reviewed at latest revision, 1 unresolved discussion. CHANGELOG.md, line 26 [r2] (raw file):
|
Review status: all files reviewed at latest revision, 1 unresolved discussion. CHANGELOG.md, line 26 [r2] (raw file):
|
ffdefa7
to
94a0f30
Compare
Review status: 20 of 21 files reviewed at latest revision, 1 unresolved discussion. CHANGELOG.md, line 26 [r2] (raw file):
|
Reviewed 1 of 1 files at r3. Comments from Reviewable |
Review status: all files reviewed at latest revision, 1 unresolved discussion. CHANGELOG.md, line 26 [r3] (raw file):
BTW: nit: Added Comments from Reviewable |
94a0f30
to
2f33540
Compare
Reviewed 3 of 3 files at r4. Comments from Reviewable |
The prior version was ripped off from stackoverflow without attribution.
2f33540
to
99e8eed
Compare
+@david-german-tri for platform review, please. |
Review status: all files reviewed at latest revision, 1 unresolved discussion. CHANGELOG.md, line 39 [r4] (raw file):
why deleted? Comments from Reviewable |
Review status: all files reviewed at latest revision, 1 unresolved discussion. CHANGELOG.md, line 39 [r4] (raw file):
|
This change is