-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Names of Model-Adding Methods #3056
Updated Names of Model-Adding Methods #3056
Conversation
@drake-jenkins-bot linux-gcc-experimental-ros please |
@drake-jenkins-bot linux-gcc-experimental-ros please Review status: 0 of 34 files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
All CI checks passed. Now waiting on #3043 to be merged before submitting this PR for review. Review status: 0 of 34 files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
…e/model_instance_id_3
+@amcastro-tri for feature review (you're the only non-platform reviewer who attended last Tuesday's meeting) @drake-jenkins-bot linux-gcc-experimental-ros please Review status: 0 of 20 files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
@drake-jenkins-bot linux-gcc-experimental-ros please Review status: 0 of 19 files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
Reviewed 15 of 25 files at r3, 2 of 4 files at r4, 1 of 11 files at r5, 1 of 3 files at r6. Comments from Reviewable |
Thanks. I'm now waiting for @amcastro-tri's feature review. Review status: Comments from Reviewable |
Reviewed 15 of 25 files at r3, 2 of 4 files at r4, 1 of 11 files at r5. Comments from Reviewable |
# Conflicts: # CHANGELOG.md
Thanks. Just waiting on CI now. It's pretty silly we need to re-run the entire pre-merge CI build just due to a CHANGELOG.md conflict. Review status: 18 of 19 files reviewed at latest revision, all discussions resolved, some commit checks pending. Comments from Reviewable |
This builds upon #3043. It renames all of the methods that add models to the
RigidBodySystem
and itsRigidBodyTree
. It also adds a bunch of Doxygen comments.This change is