Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Names of Model-Adding Methods #3056

Merged

Conversation

liangfok
Copy link
Contributor

@liangfok liangfok commented Aug 4, 2016

This builds upon #3043. It renames all of the methods that add models to the RigidBodySystem and its RigidBodyTree. It also adds a bunch of Doxygen comments.


This change is Reviewable

@liangfok
Copy link
Contributor Author

liangfok commented Aug 4, 2016

@drake-jenkins-bot linux-gcc-experimental-ros please
@drake-jenkins-bot linux-clang-experimental-ros please
@drake-jenkins-bot linux-gcc-experimental-matlab-ros please

@liangfok
Copy link
Contributor Author

liangfok commented Aug 4, 2016

@drake-jenkins-bot linux-gcc-experimental-ros please
@drake-jenkins-bot linux-clang-experimental-ros please
@drake-jenkins-bot linux-gcc-experimental-matlab-ros please


Review status: 0 of 34 files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@liangfok
Copy link
Contributor Author

liangfok commented Aug 4, 2016

All CI checks passed. Now waiting on #3043 to be merged before submitting this PR for review.


Review status: 0 of 34 files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@liangfok
Copy link
Contributor Author

liangfok commented Aug 5, 2016

+@amcastro-tri for feature review (you're the only non-platform reviewer who attended last Tuesday's meeting)
+@sherm1 for platform review (it's not Monday but you have direct knowledge of last Tuesday's meeting)

@drake-jenkins-bot linux-gcc-experimental-ros please
@drake-jenkins-bot linux-clang-experimental-ros please
@drake-jenkins-bot linux-gcc-experimental-matlab-ros please


Review status: 0 of 20 files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@liangfok
Copy link
Contributor Author

liangfok commented Aug 5, 2016

@drake-jenkins-bot linux-gcc-experimental-ros please
@drake-jenkins-bot linux-clang-experimental-ros please
@drake-jenkins-bot linux-gcc-experimental-matlab-ros please


Review status: 0 of 19 files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@sherm1
Copy link
Member

sherm1 commented Aug 5, 2016

:lgtm:


Reviewed 15 of 25 files at r3, 2 of 4 files at r4, 1 of 11 files at r5, 1 of 3 files at r6.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@liangfok
Copy link
Contributor Author

liangfok commented Aug 5, 2016

Thanks. I'm now waiting for @amcastro-tri's feature review.


Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from Reviewable

@amcastro-tri
Copy link
Contributor

:lgtm:


Reviewed 15 of 25 files at r3, 2 of 4 files at r4, 1 of 11 files at r5.
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from Reviewable

@liangfok
Copy link
Contributor Author

liangfok commented Aug 8, 2016

Thanks. Just waiting on CI now. It's pretty silly we need to re-run the entire pre-merge CI build just due to a CHANGELOG.md conflict.


Review status: 18 of 19 files reviewed at latest revision, all discussions resolved, some commit checks pending.


Comments from Reviewable

@david-german-tri david-german-tri merged commit d4ee490 into RobotLocomotion:master Aug 8, 2016
@liangfok liangfok deleted the feature/model_instance_id_3 branch March 22, 2017 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants